Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed purge-css as it was bugging out on table styling #72

Merged
merged 2 commits into from
May 5, 2021

Conversation

stephenlprice
Copy link
Member

@stephenlprice stephenlprice commented May 5, 2021

Closes #71

Removed purge-css plugin even though it was doing a great job at reducing the size of our CSS files. It was causing too many bugs with table styles.

We might re-evaluate later once the project is more complete and test this plugin once again. However, I think it adds unneeded complexity to the starter given our target audience. We should leave this decision up to each person rather than requiring it as a dependency.

@stephenlprice stephenlprice added the bug Something isn't working label May 5, 2021
@stephenlprice stephenlprice self-assigned this May 5, 2021
@stephenlprice stephenlprice added this to In progress in greenlight via automation May 5, 2021
greenlight automation moved this from In progress to Reviewer approved May 5, 2021
@trevorsmithbanjo trevorsmithbanjo merged commit 4735f3c into develop May 5, 2021
greenlight automation moved this from Reviewer approved to Done May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

remove purge-css as it causes bugs with table styles
2 participants