Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for 8.0 #133

Merged
merged 11 commits into from
May 18, 2023
Merged

Conversation

TomHAnderson
Copy link
Member

No description provided.

@TomHAnderson TomHAnderson changed the title Hotfix/code review Moved build() to AbstractContainer and implemented Entity as Buildable May 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5c74ffc) 100.00% compared to head (2650ae1) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #133   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         1283      1293   +10     
=========================================
+ Hits          1283      1293   +10     
Impacted Files Coverage Δ
src/Config.php 100.00% <ø> (ø)
src/AbstractContainer.php 100.00% <100.00%> (ø)
src/Criteria/Type/BetweenInputObjectType.php 100.00% <100.00%> (ø)
src/Driver.php 100.00% <100.00%> (ø)
src/Event/EntityDefinition.php 100.00% <100.00%> (ø)
src/Hydrator/HydratorFactory.php 100.00% <100.00%> (ø)
src/Input/InputFactory.php 100.00% <100.00%> (ø)
src/Metadata/Metadata.php 100.00% <100.00%> (ø)
src/Metadata/MetadataFactory.php 100.00% <100.00%> (ø)
src/Resolve/FieldResolver.php 100.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TomHAnderson TomHAnderson added this to the 8.0 milestone May 17, 2023
@TomHAnderson TomHAnderson changed the title Moved build() to AbstractContainer and implemented Entity as Buildable Refactor for 8.0 May 17, 2023
@TomHAnderson TomHAnderson merged commit 777132c into API-Skeletons:main May 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants