Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Add current Node.js versions to Travis CI config #26

Closed

Conversation

winniehell
Copy link
Contributor

Current LTS and stable versions of Node.js are missing from Travis CI build.

@winniehell
Copy link
Contributor Author

Interestingly, the newer Node.js versions seem to come up with a different size for the test PDF file. 0.10 to 0.12 return a size of 258441 while 4.2 and 5.4 agree on 258529. Checking the file size locally leads to yet a different result:

$ du --bytes tests/files/File.pdf 
263287  tests/files/File.pdf

Do you have any idea what happens here?

@winniehell
Copy link
Contributor Author

I've just seen that the Content-Length matches for all versions and is equal to the result of du. But why does it differ from res.text.length?

@JamesMessinger
Copy link
Member

Shit. I just realized that I have some un-pushed commits from back in October. This is one of them:
screen shot 2016-01-15 at 3 10 13 pm

@winniehell
Copy link
Contributor Author

Well, that could "fix" it. 😉
(still... what happens with these control characters is beyond my understanding...)

If you don't mind sharing the commit, that would be awesome ✨

@JamesMessinger
Copy link
Member

Actually... can you go ahead and make that change yourself? I'm going to back-out the commits I made, because it also includes breaking changes that I really should have done on a branch instead.

@winniehell
Copy link
Contributor Author

Pushed it, but hooray another one... I'll try to continue fixing them.

@winniehell
Copy link
Contributor Author

superagent adds the Content-Length header automagically, so it needs to be removed when testing for its absence. I'm not sure how this test could not fail earlier... 😉

@winniehell
Copy link
Contributor Author

Looks like all tests are running for 4 and 5 now. ✨

:shipit: ?

@JamesMessinger
Copy link
Member

Sorry for the radio silence. The past several days have been super busy for me, and I haven't even been able to get online much. I should be able to take a look at all your work in the next few days and get it merged in

@winniehell
Copy link
Contributor Author

@BigstickCarpet: no worries, I know there are still people left who have a live 😀

@winniehell winniehell mentioned this pull request Jan 22, 2016
@danyalaytekin
Copy link

Hi @BigstickCarpet - I'm using Node 8 and would be interested in using this project, if we can be confident that Node 8 is supported, and the project itself builds in CI (seems to fail currently), etc. Is the project still being maintained and will pull requests such as this one eventually be merged? Many thanks.

@winniehell
Copy link
Contributor Author

this contribution is no longer relevant, I'll close it now.

@winniehell winniehell closed this May 5, 2023
@winniehell winniehell deleted the addCurrentNode.jsToCI branch May 5, 2023 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants