Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite real fields when mutation argument is the same #100

Merged
merged 1 commit into from May 4, 2020

Conversation

alecrae
Copy link
Contributor

@alecrae alecrae commented Apr 26, 2020

Fixes #97

in #80 where passed in values from a mutation were returned in the payload if the field name is the same, this was overwritting real values whereas it should only be applied to fake values. Changing the order in which the fake and real objects are spread to construct the responses fixes this.

@IvanGoncharov
Copy link
Member

@alecrae Released as graphql-faker@2.0.0-rc.18` 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a parameter has the same name as the returned field the return value is replaced
2 participants