-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quark integration improvement #135
base: master
Are you sure you want to change the base?
Conversation
@pulorsok thanks for the PR. I tested it briefly and noted that opening smali functions from the report somehow does not work for me. Did you try that? Some notes:
|
Hi, @Surendrajat |
@pulorsok I'm seeing this error with all failing tests:
Seems like the output We're using GitHub actions and all CI code is in https://github.com/APKLab/APKLab/blob/master/.github/workflows/apklab.yml file. Also, although not much different but we're using |
@pulorsok I've fixed all issues with master branch and rebased your PR on it. I have also added a simple quark run step before actual tests on CI to simplify error debugging. Example run logs |
@Surendrajat sorry for the late response, I will fix the problem ASAP. |
Describe the feature
Hi, @Surendrajat,
We (me, @18z, @krnick) have fixed a problem and implemented a feature:
Changes in this PR:
Future work