Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quark integration improvement #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pulorsok
Copy link
Contributor

Describe the feature

Hi, @Surendrajat,
We (me, @18z, @krnick) have fixed a problem and implemented a feature:

  1. Fix the Quark execution problem
  2. Add reference treemap graph

Changes in this PR:

  • Cd to project directory before executing quark to avoid permission error when quark logfile creates at root dir
  • Add a feature that generates a quark reference treemap graph
  • Add a button in the Quark report to show reference treemap graph

Future work

  • Fix Quark execution problem on Windows platform
  • Add unit test for the treemap feature

@Surendrajat
Copy link
Member

Surendrajat commented Jul 18, 2021

@pulorsok thanks for the PR. I tested it briefly and noted that opening smali functions from the report somehow does not work for me. Did you try that?
Also, I believe we can't merge it until the windows issue is resolved so maybe make it as draft for now.

Some notes:

  • graphviz is a hard dependency of Quark-Engine
  • Windows tests are failing even on master
  • We're using yarn instead of npm

@pulorsok
Copy link
Contributor Author

Hi, @Surendrajat
Sorry for taking so long to respond.
I try to solve the problem by editing the execute cmd for Windows and testing on three platforms (Linux, OSX, Windows). Each platform is tested well locally (using npm test). Unfortunately, it seems the Travis CI still does not work. So could you provide some log messages to help me solve the problem? Thank you :)

@Surendrajat
Copy link
Member

@pulorsok I'm seeing this error with all failing tests:

AssertionError [ERR_ASSERTION]: Analysis Report file /home/runner/work/APKLab/APKLab/testdata/simplekeyboard/test/quarkReport.json not found!

Seems like the output quarkReport.json file is not being detected. See if you can verify if it's there during test somehow or I'll do it when I get time.

We're using GitHub actions and all CI code is in https://github.com/APKLab/APKLab/blob/master/.github/workflows/apklab.yml file.

Also, although not much different but we're using yarn instead of npm now.

@Surendrajat Surendrajat added improvement Improvement in an existing feature quark Quark-Engine related issues or PR labels Aug 15, 2021
@Surendrajat
Copy link
Member

Surendrajat commented Oct 14, 2021

@pulorsok I've fixed all issues with master branch and rebased your PR on it. I have also added a simple quark run step before actual tests on CI to simplify error debugging. Example run logs

@pulorsok
Copy link
Contributor Author

@Surendrajat sorry for the late response, I will fix the problem ASAP.
And thanks for the kind help 😄

@Surendrajat Surendrajat added the waiting-for-dev Waiting for developer as it's been some time label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement in an existing feature quark Quark-Engine related issues or PR waiting-for-dev Waiting for developer as it's been some time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants