Adds preferredAspectRatio instances object support #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly support including a
preferredAspectRatio
object in theimage
prop, I did a bit of a refactor of this component. Primarily this was to separate the concerns a little bit more, using a more functional style with return values and getting rid of theimageProps
var, as well as separating things out into a few more functions.Some of the tests had to be revised a little bit because they weren't quite testing for the correct behavior, and I added another test for the aforementioned
preferredAspectRatio
object. As a note, in the data,preferredAspectRatio
exists as a sibling toaspect_ratios
, not as a child. This is what necessitated the re-work