Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set the graph axis name when it's manually set #8784

Open
par456 opened this issue Mar 26, 2024 · 3 comments
Open

Only set the graph axis name when it's manually set #8784

par456 opened this issue Mar 26, 2024 · 3 comments
Labels
Improvement An enhancement to an existing functionality or system

Comments

@par456
Copy link
Collaborator

par456 commented Mar 26, 2024

Describe the new feature

When a graph is created, it often sets the axis name into the axis that is then stored, even if the axis was not manually named. This then causes the name to be copied when the graph is copied and doesn't update when the X or Y axis value is changed. Leading to graphs with incorrectly named axis when you are making a lot at once and working from copies.

Should fix this so that the axis name is only saved if it was actually manually renamed, otherwise it should continue to change based on what the variable it has been set to.

Might need to also clear old graphs that have an axis with the generated name stored so that older files share the behaviour.

@par456 par456 added the Improvement An enhancement to an existing functionality or system label Mar 26, 2024
@par456
Copy link
Collaborator Author

par456 commented Mar 28, 2024

Wrong PR linked, ignore that.

@ric394
Copy link
Contributor

ric394 commented Jun 17, 2024

Was unable to replicate the behaviour mentioned. Has this been fixed with another PR @par456?
Feel free to reopen if I'm incorrect, but I'll close this as it doesn't seem to be an issue on tip.

@ric394 ric394 closed this as completed Jun 17, 2024
@par456
Copy link
Collaborator Author

par456 commented Jun 17, 2024

The issue may have been fixed, but there are a lot of old graphs hanging around with locked axis names due to the text being saved.

So the 2nd part of this issue is to write some code (maybe in the converter) to clear a graph's axis name if the name it has is the same one that the graph system would automatically generate. That way we can 'unset' some of these axis that have been incorrectly set to a name.

@par456 par456 reopened this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement An enhancement to an existing functionality or system
Projects
Status: Backlog
Development

No branches or pull requests

2 participants