Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8717 Zadok Changes #8722

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

par456
Copy link
Collaborator

@par456 par456 commented Feb 29, 2024

Resolves #8717
Working on #8493

Some strange points were found in the Zadok.Stage of the wheat validation. Notably, in the MouseRemoval experiments, it had a Zadok Stage of 0 entered 35 day prior to the crop being sown, and a zadok stage of 90 after the crop had been harvested with no clock.today value which broke the graphs (see issue #8713 which will need to reproduce this now). These have been removed as errors.

The MouseRemoval experiment also had a Zadok.Stage observation recorded the same day as the crop was harvested, which meant apsim was reporting back a stage of 0 when the observation was 86. To fix this the apsim harvest was delayed to the day after.

In the Lonzee experiments, a Zadok Stage of 0 was observed on the day of the crop being sown, but apsim was reporting a score of 4.995 that day. To resolve this, the germination phase will now report back a stage of 0, as on the 2nd day of the crop it will move into the start of the emergence phase like before. This just allows for more sensible reporting on the first day. Will have to see how this impacts our stats, as it may effect other crops.

@par456
Copy link
Collaborator Author

par456 commented Feb 29, 2024

This did change the barley stats, but only because barley has 4 points where the crop has been harvested in Apsim, but the observations are on or after that date.

Basically, the comparisons of 92 observed to 4.995 predicted, are now 92 observed to 0 predicted. So they did get worse, but only for measurements that were already a problem.

@hol353 hol353 merged commit 0494c45 into APSIMInitiative:master Mar 1, 2024
2 checks passed
@par456 par456 deleted the 8493ZadokStageObs branch March 21, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zadok Stage on day of sowing is 4.9
2 participants