remove low leaf area test #1951
Conversation
|
Don't you think it's better to move the test or the error handler to after lai += dltLAI;? |
|
@BrianCollinss The piece of code that was replaced wasn't checking if dltLAI was larger than LAI. We're not sure what it's purpose was - it's been there a long time. The exception would show if the code was there to keep LAI > 0 - but it doesn't look like that was it's intent. |
|
You're right. I am just thinking that if if(lai < 0.001) lai = 0.0 is left in place, lai += dltLAI could make the LAI<0, because lai=0. |
Model/Sorghum/Leaf.cpp
Outdated
|
|
||
| senescedLAI = Max(0.0,lai - 0.1); | ||
| // FIXME - which is it? 0.01 or 0.1? If it's a fraction, then shouldn't we | ||
| // multiply by 0.9? |
There was a problem hiding this comment.
@jbrider - query here. Fractional loss, or 0.1?
There was a problem hiding this comment.
It was 0.1 to remove most of the leaf but retain enough that it wasn't killed due to loss of leaf.
|
Abandoned, another go at #1979 |
Working on #1950
Test to find damage