Update the debug handlers options for verbosity #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the commands are using the standard -v verbosity in the argparser, the help for the command shows that there are four verbosity levels. At the moment if you run python manage.py send_mail -v3 for instance, it fails with a cryptic message about the key "3" not being present in the LOGGING_LEVEL dictionary. This just duplicates the "2" key so that both 2 and 3 verbosity have the DEBUG message level. An alternative would be to specify the -v option in each of the commands to only allow -v[0/1/2].
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 64.39% 64.39%
=======================================
Files 14 14
Lines 660 660
Branches 58 58
=======================================
Hits 425 425
Misses 214 214
Partials 21 21
Continue to review full report at Codecov.
|
|
Hi @davepeake, Thanks for the pull request. We are quite busy right now but we will review it as soon as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the commands (send_mail etc.) are using the standard -v verbosity in the arg parser, the help for the command shows that there are four verbosity levels (0-3). At the moment if you run
python manage.py send_mail -v3
for instance, it fails with a cryptic message about the key "3" not being present in the LOGGING_LEVEL dictionary. This change duplicates the "2" key so that both 2 and 3 verbosity have the DEBUG message level.
An alternative would be to specify the -v option in each of the commands to only allow -v[0/1/2].