For the button to add the activeOpacity attribute interface #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add activeOpacity Props interface , let the button pressingStyle more flexible
add activeOpacity props describe
Add the activeOpacity props the test
|
Thanks for the PR @moxiaohui! Can you try to squash your commits? |
|
Hi there, any news about that? Thanks. |
| @@ -3,6 +3,12 @@ import Button from 'apsl-react-native-button' | |||
|
|
|||
| export default class Example extends React.Component { | |||
| render () { | |||
| var onPressProps; | |||
There was a problem hiding this comment.
Better use let if possible.
|
Yes! sorry folks @moxiaohui @matteomunaretto I can merge this later today. |
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the button to add the activeOpacity attribute interface, let the button click effect is more flexible.
Example of the second button Add the attribute test.
Add a description of the property the Readme.md.