Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some props of KeyboardAwareListView are not required #60

Closed
whs opened this issue Aug 26, 2016 · 2 comments
Closed

Some props of KeyboardAwareListView are not required #60

whs opened this issue Aug 26, 2016 · 2 comments

Comments

@whs
Copy link

whs commented Aug 26, 2016

KeyboardAwareListView inherited propTypes from ListView. Some of the props there are listed with .isRequired but do have default props set. As KeyboardAwareListView doesn't have default props, this would trigger some warnings in development mode.
@alvaromb
Copy link
Collaborator

alvaromb commented Sep 8, 2016

Hi @whs!

What do you recommend to avoid the warnings?

@whs
Copy link
Author

whs commented Sep 8, 2016

I think this line can be removed. If some of the ListView required props are missing it would complain using its own propTypes directly.

alvaromb pushed a commit that referenced this issue Dec 19, 2016
closes #60 Solves ListView warnings with the passed props
6c9c97a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alvaromb @whs