Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use root project settings for compileSdkVersion, buildToolsVersion, etc #27

Merged
merged 1 commit into from
May 15, 2019

Conversation

maxmamis
Copy link
Contributor

No description provided.

@maxmamis maxmamis changed the title Update build.gradle use root project settings for compileSdkVersion, buildToolsVersion, etc Jul 11, 2018
@maxmamis
Copy link
Contributor Author

This allows the project to upgrade to a newer android SDK version (as required by React Native 0.5.6)

@ethanneff
Copy link

can confirm this works for latest version of React Native (0.56.0)

@MrHubble
Copy link

MrHubble commented Sep 7, 2018

Is there anything stopping this from being merged into a new release?

@franck-nadeau
Copy link

I would like to confirm that this fix works. It would be nice for it to be merged in this project.

@annelorraineuy
Copy link

This package was updated recently. It would have been great if this PR was included.

@denisw
Copy link

denisw commented Apr 8, 2019

The build is broken without this change:

Execution failed for task ':react-native-version-number:lint'.
> Lint found errors in the project; aborting build.

  Fix the issues identified by lint, or add the following to your build script to proceed with errors:
  ...
  android {
      lintOptions {
          abortOnError false
      }
  }
  ...

  Errors found:

  /Users/dwas/Projects/Bosch/pro360.mobile.inventory-app/node_modules/react-native-version-number/android/build.gradle:10: Error: Google Play requires that apps target API level 26 or higher.
   [ExpiredTargetSdkVersion]
          targetSdkVersion 22
          ~~~~~~~~~~~~~~~~~~~

@alvaromb alvaromb merged commit 93287e3 into APSL:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants