Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with the new syntax without configure the templating #36

Closed
wants to merge 1 commit into from

Conversation

Sentence
Copy link

@Sentence Sentence commented Jan 23, 2018

The bundle isn't compatible with Symfony 3.4+ or 4+.

1st method, the configuration (without apply @Richard87's patch, #35, but also need to remove the hardcoding dependency):

a) We need to configure the old templating in the config.yml, now the bundle can use the templating service

# app/config/config.yml
framework:
    templating:
        engines: ['twig']

b) Override the template in config.yml

apy_breadcrumb_trail:
    template: '@APYBreadcrumbTrail/breadcrumbtrail.html.twig'

2nd method, the bundle patch to v2 with this pull request.

@Sentence Sentence closed this Mar 14, 2018
@Sentence Sentence deleted the s4 branch March 14, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant