Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test PHP8 via CI, and allow PHP7.2 #58

Merged
merged 6 commits into from
Apr 8, 2021
Merged

Test PHP8 via CI, and allow PHP7.2 #58

merged 6 commits into from
Apr 8, 2021

Conversation

rvanlaak
Copy link
Collaborator

@rvanlaak rvanlaak commented Apr 8, 2021 •
edited

PHP 8.0 already was supported on master as the composer constraint is >=7.3.

This PR

  • adds test coverage for PHP8.0 and Symfony 5.2, and
  • also allows PHP7.2 again as there was no reason to not support it. People themselves should be aware that PHP7.2 is EOL and they should upgrade asap. https://www.php.net/supported-versions.php

@rvanlaak rvanlaak changed the title Test PHP8 via CI Test PHP8 via CI, and allow PHP7.2 Apr 8, 2021
@rvanlaak rvanlaak marked this pull request as ready for review April 8, 2021 14:02
@rvanlaak rvanlaak merged commit e446c7b into master Apr 8, 2021
@rvanlaak rvanlaak deleted the php-80 branch April 8, 2021 14:02
@rvanlaak rvanlaak mentioned this pull request Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rvanlaak