Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed YAML in example configuration #1039

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

romaricdrigon
Copy link
Contributor

Hello,

This PR fixes a small typo: in YAML, backslashes should be escaped.
Copy-pasting example configuration would crash the application with Symfony >= 3 (and a deprecation warning with Symfony 2.8).

image

As far I know, it does not break BC (since escaping \ is part of YAML specification).

Copy link
Collaborator

@npotier npotier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this deprecation is well documented here : https://symfony.com/blog/new-in-symfony-2-8-yaml-deprecations

Thank you @romaricdrigon. it sounds good to me

@romainguerrero
Copy link
Collaborator

Thanks @romaricdrigon . May you rebase your branch on the master one to get a modification on the travis setup ?

@romainguerrero
Copy link
Collaborator

Well, I merge it as it concern only the documentation

@romainguerrero romainguerrero reopened this Apr 1, 2020
@romainguerrero romainguerrero merged commit 167cbcf into APY:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants