Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespaced twig paths #1074

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Use namespaced twig paths #1074

merged 1 commit into from
Apr 19, 2022

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Apr 14, 2022

This is available since twig-bundle 2.2

@deguif
Copy link
Contributor Author

deguif commented Apr 15, 2022

It's also an issue in Symfony projects which use Twig engine directly without passing by the deprecated templating engine, as the old format is not supported.

@deguif
Copy link
Contributor Author

deguif commented Apr 19, 2022

@npotier any change to get this merged quickly, this is triggering errors on our side as we removed use of the templating engine to instead use twig directly?

@npotier npotier merged commit 014c560 into APY:master Apr 19, 2022
@npotier
Copy link
Collaborator

npotier commented Apr 19, 2022

Hello @deguif thank you for this PR.

I trust you on this one, thank you for having updated the doc.

@deguif deguif deleted the twig-namespaced-path branch April 26, 2022 14:03
@deguif
Copy link
Contributor Author

deguif commented Apr 26, 2022

@npotier I can confirm that this fixes the issue encountered ;)

@npotier
Copy link
Collaborator

npotier commented Apr 26, 2022

Thanks for the feedback 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants