Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations #997

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Fix translations #997

merged 1 commit into from
Apr 30, 2018

Conversation

dfridrich
Copy link
Contributor

No description provided.

@dfridrich
Copy link
Contributor Author

Ping @Abhoryo

@DonCallisto
Copy link
Member

@dfridrich, @Abhoryo isn't the maintainer anymore.
I will take a look at this that I didn't noticed (FYI I'm not the maintainer that is @hmert)

@@ -198,6 +198,14 @@
<source>No result</source>
<target>No result</target>
</trans-unit>
<trans-unit id="45">
<source>Selected _s_ rows</source>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this _s_ here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this:

selected.innerHTML = counter > 0 ? '{{ 'Selected _s_ rows'|trans }}'.replace('_s_', counter) : '';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it

@DonCallisto
Copy link
Member

@dfridrich could you squash commits into single one with meaningful message?
Thanks.

@dfridrich
Copy link
Contributor Author

@DonCallisto squashed ;-)

@DonCallisto DonCallisto merged commit cc423d7 into APY:master Apr 30, 2018
@DonCallisto
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants