Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Barcode types and nftMarker struct to get NFT data #469

Merged
merged 6 commits into from
Nov 4, 2022

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Oct 25, 2022

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?

Add more support for Barcode markers 5x5 and 6x6 types and will also let loading important NFT marker informations/data.
Can it be referenced to an Issue? If so what is the issue # ?
See issues #37 and #4 and PR AR-js-org/artoolkit5-js#17 and for what concern nftData see old PR #114
How can we test it?

In the minimal_ES6.html example change the type to marker 5x5, generate a 5x5 barcode n. 0 with https://au.gmented.com/app/marker/marker.php point your device and a cube will appear.
Test the threejs/examples/nft.html example for the automatic repositioning. You will find in the example code the new eventListener arjs-nft-init-data.
Summary

AR.js is based on ARToolkit5 code ported to WebAssembly, but some barcode types weren't added as constants to artoolkit5-js. These new constants now are added and we can import into AR.js. Probably we can add other types, (and maybe i will add them), but i can't say about their characteristics or say if they perform better in comparison to other yet implemented.

EDIT: These are the Barcode types implemented with this PR:

  • AR_MATRIX_CODE_5x5_BCH_22_12_5
  • AR_MATRIX_CODE_5x5_BCH_22_7_7
  • AR_MATRIX_CODE_5x5
  • AR_MATRIX_CODE_6x6

About the nft Data: it is possible to obtain the NFT's basic informations reading from the set of .iset .fset .fset3 files, data like dpi width and height. These can be useful for an automatic reposition of the model onto the image target.

Does this PR introduce a breaking change?
It shouldn't but i will make some test.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
For now only tested on a desktop PC running OpenSuse.
Other information

- 5x5 and 6x6 see #37
@kalwalt kalwalt added enhancement New feature or request pattern barcode about barcode markers dependencies Pull requests that update a dependency file labels Oct 25, 2022
@kalwalt kalwalt self-assigned this Oct 25, 2022
@kalwalt
Copy link
Member Author

kalwalt commented Oct 25, 2022

I will add more infos this Pr in the next hours/days, but i think the most feaures are implemented. The new event will not works for the Aframe lib, for now it's better to test only under Threex.

@kalwalt kalwalt merged commit c8b09d5 into dev Nov 4, 2022
@nicolocarpignoli nicolocarpignoli deleted the feature-nftMarker-barcode branch November 8, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request pattern barcode about barcode markers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant