Updating policies

ARCANESOFT · Feb 23, 2017 · 5232bfd · 5232bfd
1 parent c8daa9d
commit 5232bfd
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 70 deletions.
diff --git a/src/Policies/AbstractPolicy.php b/src/Policies/AbstractPolicy.php
@@ -0,0 +1,14 @@
+<?php namespace Arcanesoft\Foundation\Policies;
+
+use Arcanesoft\Core\Bases\Policy;
+
+/**
+ * Class     AbstractPolicy
+ *
+ * @package  Arcanesoft\Foundation\Policies
+ * @author   ARCANEDEV <arcanedev.maroc@gmail.com>
+ */
+abstract class AbstractPolicy extends Policy
+{
+    //
+}
diff --git a/src/Policies/LogViewerPolicy.php b/src/Policies/LogViewerPolicy.php
@@ -8,41 +8,21 @@
  * @package  Arcanesoft\Foundation\Policies
  * @author   ARCANEDEV <arcanedev.maroc@gmail.com>
  */
-class LogViewerPolicy extends Policy
+class LogViewerPolicy extends AbstractPolicy
 {
-    /* ------------------------------------------------------------------------------------------------
+    /* -----------------------------------------------------------------
      |  Constants
-     | ------------------------------------------------------------------------------------------------
+     | -----------------------------------------------------------------
      */
     const PERMISSION_DASHBOARD = 'foundation.logviewer.dashboard';
     const PERMISSION_LIST      = 'foundation.logviewer.list';
     const PERMISSION_SHOW      = 'foundation.logviewer.show';
     const PERMISSION_DOWNLOAD  = 'foundation.logviewer.download';
     const PERMISSION_DELETE    = 'foundation.logviewer.delete';
 
-    /* ------------------------------------------------------------------------------------------------
-     |  Getters and Setters
-     | ------------------------------------------------------------------------------------------------
-     */
-    /**
-     * Get the policies.
-     *
-     * @return array
-     */
-    public static function getPolicies()
-    {
-        return [
-            'dashboardPolicy' => static::PERMISSION_DASHBOARD,
-            'listPolicy'      => static::PERMISSION_LIST,
-            'showPolicy'      => static::PERMISSION_SHOW,
-            'downloadPolicy'  => static::PERMISSION_DOWNLOAD,
-            'deletePolicy'    => static::PERMISSION_DELETE,
-        ];
-    }
-
-    /* ------------------------------------------------------------------------------------------------
-     |  Policies Functions
-     | ------------------------------------------------------------------------------------------------
+    /* -----------------------------------------------------------------
+     |  Abilities
+     | -----------------------------------------------------------------
      */
     /**
      * Allow to view the LogViewer dashboard.

diff --git a/src/Policies/Policy.php b/src/Policies/Policy.php
diff --git a/src/Providers/AuthorizationServiceProvider.php b/src/Providers/AuthorizationServiceProvider.php
@@ -1,9 +1,7 @@
 <?php namespace Arcanesoft\Foundation\Providers;
 
 use Arcanedev\Support\Providers\AuthorizationServiceProvider as ServiceProvider;
-use Arcanesoft\Contracts\Auth\Models\User;
-use Arcanesoft\Foundation\Policies;
-use Illuminate\Support\Facades\Gate;
+use Arcanesoft\Foundation\Policies\LogViewerPolicy;
 
 /**
  * Class     AuthorizationServiceProvider
@@ -25,21 +23,12 @@ public function boot()
         $this->registerPolicies();
 
         /** @var  \Illuminate\Auth\Access\Gate  $gate */
-        Gate::before(function (User $user, $ability) {
-            return $user->isAdmin() ? true : null;
-        });
+//        Gate::before(function (User $user, $ability) {
+//            return $user->isAdmin() ? true : null;
+//        });
 
-        $this->registerLogViewerPolicies();
-    }
+        // TODO: Add more policies for other foundation features.
 
-    /**
-     * Register LogViewer policies.
-     */
-    private function registerLogViewerPolicies()
-    {
-        $this->defineMany(
-            Policies\LogViewerPolicy::class,
-            Policies\LogViewerPolicy::getPolicies()
-        );
+        $this->defineMany(LogViewerPolicy::class, LogViewerPolicy::policies());
     }
 }