-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
96 download thumbnail #109
base: develop
Are you sure you want to change the base?
Conversation
Linked to #96 |
Here also conflicts needs to be resolved anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails the postman test, not quite sure why.
I believe the test can also be executed in postman (either local or using postman web), and this is the test file: https://github.com/ARETEedu/moodle-mod_arete/blob/develop/tests/postman/Moodle%20Arete.postman_collection.json
Essentially, the upload test seems to fail, see last pipeline action run: https://github.com/ARETEedu/moodle-mod_arete/actions/runs/5414182421/jobs/9841087368
Weirdly, it looks like the test before that is trying to delete the file, so this may just be a bit messed up…?
To fix, I would recommend to run the tests in postman from a local postman (so that the upload tests have access to the two local files in the tests folder: https://github.com/ARETEedu/moodle-mod_arete/tree/develop/tests/postman - and either fix the test (if obvious) or remove the test. but it may also fix it if we merge in the remaining two open PR requests? As one of them (119) does changes in the test: https://github.com/ARETEedu/moodle-mod_arete/pull/120/files
Unfortunately, I'm not familier with the PHP testing that much. I just testet the plugin and every thing seems work like before. therefore I merge them. So I don't know what changes have been done on test file by @geopsirra that made tests failed. |
Adding downloading thumbnail feature