ARGO-1600 Add push server interaction on modify push config api call #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agelostsal
force-pushed
the
mod-push-cfg
branch
2 times, most recently
from
27d90d3
to
f4521e7
Compare
|
test this please |
agelostsal
changed the title
agelostsal
force-pushed
the
mod-push-cfg
branch
from
f4521e7
to
fc64149
Compare
agelostsal
force-pushed
the
mod-push-cfg
branch
from
fc64149
to
799506b
Compare
kaggis
approved these changes
Mar 1, 2019
agelostsal
pushed a commit
to agelostsal/argo-messaging
that referenced
this pull request
Mar 1, 2019
ARGO-1600 Add push server interaction on modify push config api call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the modifyPushConfig action is called, we check if the subscription has an active push config in order to deactivate it. If there was no prior push config active we skip this step. Next, we check if the push config in the request is activated or deactivated(null or not) in order to activate the subscription with the new values.