Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster PDF preview generation #153

Closed
kirillt opened this issue Dec 7, 2021 · 2 comments
Closed

Faster PDF preview generation #153

kirillt opened this issue Dec 7, 2021 · 2 comments
Assignees
@j4w3ny
Labels
enhancement New feature or request performance

Comments

@kirillt
Copy link
Member

kirillt commented Dec 7, 2021

Right now, we use https://github.com/barteksc/PdfiumAndroid for rendering PDF previews.
The library is loaded per each document instead of loading it once per batch,
because it doesn't have API to re-use instance several times.

We should consider alternatives:
https://pspdfkit.com/guides/android/viewer/kotlin/
https://developer.android.com/reference/android/graphics/pdf/PdfRenderer.html
https://github.com/pdf-rs/pdf
@kirillt kirillt added enhancement New feature or request performance labels Dec 7, 2021
@kirillt kirillt self-assigned this Dec 21, 2021
@kirillt
Copy link
Member Author

kirillt commented Dec 24, 2021

Testing data:
https://www.taran.space/dev/TEST_PDF.zip

@kirillt kirillt assigned kirillt and unassigned kirillt Feb 2, 2022
@kirillt kirillt mentioned this issue Feb 8, 2022
Closed
@cnzqa cnzqa mentioned this issue Apr 1, 2022
Closed
This was referenced May 30, 2022
Closed
Closed
@kirillt kirillt assigned pgpathan22 and unassigned kirillt Jun 5, 2022
@kirillt kirillt assigned j4w3ny and unassigned pgpathan22 Jul 10, 2022
This was referenced Dec 4, 2022
Closed
Closed
Merged
@kirillt kirillt mentioned this issue Feb 16, 2023
Merged
@kirillt
Copy link
Member Author

kirillt commented Feb 16, 2023

#329

@kirillt kirillt closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j4w3ny j4w3ny

Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kirillt @j4w3ny @pgpathan22