TagsSelector undo feature #82
Conversation
mdrlzy
force-pushed
the
18-tags-selector-undo
branch
from
c3f8f8c
to
fd4a584
Compare
...in/java/space/taran/arknavigator/mvp/presenter/adapter/tagsselector/TagsSelectorPresenter.kt
Outdated
Show resolved
Hide resolved
|
|
||
| private fun verifyActions() { | ||
| if (storage == null || index == null) | ||
| return |
There was a problem hiding this comment.
Is it probable case that storage or index are nulls? If it is possible only in case of a bug, then throw AssertionError("detailed message") should be used.
There was a problem hiding this comment.
storage and index are null's while indexing is in progress and the user can tap "back"
But we handle this case by checking actions.isEmpty()
There was a problem hiding this comment.
If we handle this case in other place (onBackClick() IIUC), then this return is confusing since we never reach it in fact. I would replace it with AssertionError then to catch a bug if we are wrong. Technically, we need to put it only for debug mode, but at this stage of project we don't really have production :)
|
Let's add #83 into this PR ( |
mdrlzy
force-pushed
the
18-tags-selector-undo
branch
from
fd4a584
to
d9f17b9
Compare
mdrlzy
force-pushed
the
18-tags-selector-undo
branch
from
91a2f55
to
0ea0296
Compare
mdrlzy
force-pushed
the
18-tags-selector-undo
branch
from
0ea0296
to
5635c0a
Compare
#18