#45: Change the parameter's type of update_one to generic Path
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillt
reviewed
Nov 4, 2023
kirillt
reviewed
Nov 4, 2023
kirillt
reviewed
Nov 4, 2023
| @@ -340,38 +340,47 @@ impl ResourceIndex { | |||
|
|
|||
| pub fn update_one( | |||
| &mut self, | |||
| path_buf: CanonicalPathBuf, | |||
| path: &dyn AsRef<Path>, | |||
kirillt
reviewed
Nov 16, 2023
Comment on lines
+413
to
+428
| let old_path = self | ||
| .path2id | ||
| .drain() | ||
| .into_iter() | ||
| .filter_map(|(k, v)| { | ||
| if v.id == old_id { | ||
| Some(k) | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| .collect_vec(); | ||
| for p in old_path { | ||
| self.path2id.remove(&p); | ||
| } | ||
| self.id2path.remove(&old_id); |
There was a problem hiding this comment.
Probably we should handle collisions differently to remove necessity iterate through path2id. But this should be implemented as separate issue.
There was a problem hiding this comment.
kirillt
approved these changes
Nov 16, 2023
kirillt
changed the title
update_one to generic Path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #45 by changing the update_one parameter to
Asref<Path>