FIX: outdated text in masking_data_with_gatefilters.ipynb #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an odd number prevents single index offsets in placement in case of an even size
Also, modify the default window size to 3 instead of the previous value of 4 (even number resulting in a potential offset).
Conflicts: tests/retrieve/test_simple_moment_calculations.py
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@isilber Thanks for the catch! Merging! |
zssherman
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gate_idvalues provided in the comment were corrected.Since I couldn't find the
sgpxsaprcmacsurI5.c1datastream on the archive, I verified the values in one of cmac product's recent files.Note that we could also add a note to that comment stating that
gate_idis a cmac variable rather than some internally-processed Py-ART field, which could prevent user confusion