Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: GateFilter available for 4DD #308

Merged
merged 1 commit into from Aug 6, 2015

Conversation

kirknorth
Copy link
Collaborator

Adding the ability to input a radar GateFilter when dealiasing Doppler velocities with the James et al. (2001) 4-D algorithm. Note that certain kwargs are now deprecated (e.g., extra_prep) but I'll let @jjhelmus decide if these kwargs should be permanently removed or kept for backwards compatibility.

Adding the ability to input a radar GateFilter when dealiasing Doppler
velocities with the James et al. (2001) 4-D algorithm. Note that certain
kwargs are now deprecated (e.g., extra_prep) but I'll let @jjhelmus
decide if these kwargs should be permanently removed or kept for
backwards compatibility.
@jjhelmus
Copy link
Contributor

jjhelmus commented Jun 2, 2015

This is great @kirknorth! I think deprecating a number of the parameters in this function makes sense and will make the gatefilter the only method for filtering gates prior to applying the 4-D algorithm. Marking the following parameters as depreciated and removing them after the next release of Py-ART is reasonable:

  • extra_prep
  • ncp_min
  • rhi_min
  • ncp_field
  • rhv_field

In additional the following parameters can also be Depreciated if the _fourdd_interface file is adjust as needed. Reflectivity filtering would then be done when creating the Gatefilter:

  • refl_field
  • prep
  • lowdbz (not explicitly mentioned in the docs)
  • highdbz (not explicitly mentioned in the docs)
  • rm_missing (not explicitly mentioned in the docs)

Anyone have concerns about these changes?

@jjhelmus
Copy link
Contributor

jjhelmus commented Jun 9, 2015

Issue #253 can also be addressed by this PR.

@jjhelmus
Copy link
Contributor

jjhelmus commented Aug 6, 2015

@kirknorth Mind if I create a branch off this PR to remove the depreciated parameters as well as the reflectivity filtering in FourDD? I think having the gatefilter be the only method for specifying what gates are excluded is best. It will take some mucking with the Cython and C files so I think a separate branch and PR will be easier than trying to merge into this one.

@kirknorth
Copy link
Collaborator Author

Sure thing @jjhelmus! And yes I agree, I think removing all hard thresholds (e.g., min_ncp, max_refl, etc.) from Py-ART functions and instead rely on the more codified GateFilter class is the proper way to move forward.

@jjhelmus jjhelmus merged commit bee8fef into ARM-DOE:master Aug 6, 2015
@kirknorth kirknorth deleted the fourdd-filter branch October 15, 2015 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants