Add plot azimuthal cross-section to radardisplay class.

[nguy]

This PR is in response to Issue #398

[jjhelmus]

Just a style issue:
This line is not properly aligned with "self" in the line above and there should be a space after the comma.

[nguy]

Changed

[jjhelmus]

This looks really great @nguy, thanks for adding this. A few comments, ideas:

• It looks like your editor is not stripping trailing whitespace. Removing trailing whitespace is a good practice and recommended by PEP8, Python's style guide. A google search should pull up instructions on how to configure your editor to do this automatically.
• Any change you could add a unit test for the new method? test_xsect.py and test_radar_display.py should give you some examples. For graphing there is typically no artifacts to tests, the assumption is that if the code run and a plot was generated then everything is good. Not exactly the best testing mentality but better than nothing.
• The gatefilter and filter_transitions parameters are not used in the method. I think they can be passed to the _get_azimuth_rhi_data_x_y_z method and used to filter the data in the same manner as is used by the _get_data method.

Again thanks for the code!

[jjhelmus]

ray is not defined in this scope and I don't believe a slice is required here at all.

[nguy]

You are correct, good catch. The dangers of copy and paste!

[nguy]

@jjhelmus Thanks for the tip, I wondered why I always seemed to have these issue!
I just adjusted my settings, so hopefully this will help. What editor do you use? It seems like you told me vim?

I had gatefilter and filter_transitions in there, not sure why I took those out.

I'll take a look at the test files you mention and see what I can do.

[nguy]

Let me know if that test works for you. Other comments are added.

[jjhelmus]

I use vim/Gvim/Macvim depending on the computer within reach and my mood.

I have the following in my .vimrc for removing whitespace. It does it automatically when .py files are saved and I can fit F5 to do manually.

" Functions
function! <SID>StripTrailingWhitespaces()
    " Preparation: save last search, and cursor position.
    let _s=@/
    let l = line(".")
    let c = col(".")
    " Do the business:
    %s/\s\+$//e
    " Clean up: restore previous search history, and cursor position
    let @/=_s
    call cursor(l, c)
endfunction

" call with <F5> and turn on for all Python files
nnoremap <silent> <F5> :call <SID>StripTrailingWhitespaces()<CR>
autocmd BufWritePre *.py :call <SID>StripTrailingWhitespaces()

I also put a bunch of other stuff in my .vimrc and .gvimrc files, all of them are in my dotfiles repository

[jjhelmus]

Looks good to me. I'll merge this once the AppVeyor tests pass. Thanks again @nguy.

[nguy]

You bet, I figured I could get this in quickly and give myself a feeling of accomplishment this week. :)

[scollis]

Nice work @nguy !!

-sent from a mobile device-

On Oct 23, 2015, at 3:45 PM, Nick notifications@github.com wrote:

You bet, I figured I could get this in quickly and give myself a feeling of accomplishment this week. :)

—
Reply to this email directly or view it on GitHub.