Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scalar version of transpose conv s8 #82

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add scalar version of transpose conv s8 #82

merged 2 commits into from
Nov 6, 2023

Conversation

mansnils
Copy link
Contributor

@mansnils mansnils commented Nov 2, 2023

Adds initial support for transpose conv with unit tests as well.

@mansnils
Add scalar version of transpose conv s8
93cbbfd 
Change-Id: Ibb996384de9d406980f46927ee33fba92e379e0a
@mansnils mansnils added the feature New features label Nov 2, 2023
felix-johnny
felix-johnny reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@felix-johnny felix-johnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've added some minor comments..

Include/arm_nnfunctions.h Outdated Show resolved Hide resolved
Include/arm_nnfunctions.h Outdated Show resolved Hide resolved
Include/arm_nnsupportfunctions.h Show resolved Hide resolved
Source/ConvolutionFunctions/arm_transpose_conv_s8.c Outdated Show resolved Hide resolved
Source/NNSupportFunctions/arm_nn_mat_mult_nt_t_s32.c Outdated Show resolved Hide resolved
@felix-johnny
Copy link
Contributor

Looks ok. I'll let Adrian do the final ok..

@mansnils mansnils merged commit ca47625 into ARM-software:main Nov 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-johnny felix-johnny felix-johnny left review comments

@AdrianLundell AdrianLundell AdrianLundell approved these changes

Assignees
No one assigned
Labels
feature New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mansnils @felix-johnny @AdrianLundell