Add ACLE macros for FEAT_PAuth_LR #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement to the Pointer Authentication extension where the value of PC is used as a diversifier when signing pointers. This updates the ACLE to support the extension by the introduction of a new feature marcro and the addition of a new possible value to the existing `__ARM_FEATURE_PAC_DEFAULT` macro.
vhscampos
requested changes
Jan 29, 2024
|
Thank's @vhscampos ! I've fixed the items from the comments and the typo in the PR description. I'll make sure it's also fixed on the commit message when the change is merged. |
vhscampos
approved these changes
Jan 29, 2024
|
LGTM. Thank you! |
|
@all-contributors please add @pratlucas for code |
|
I've put up a pull request to add @pratlucas! 🎉 |
pratlucas
added a commit
to pratlucas/llvm-project
that referenced
this pull request
Jan 31, 2024
This updates clang's target defines to include the ACLE changes covering the FEAT_PAuth_LR architecture extension. The changes include: * The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when FEAT_PAuth_LR is available in the target. * A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro, indicating the use of PC as a diversifier for Pointer Authentication (from -mbranch-protection=pac-ret+pc). The approved changes to the ACLE spec can be found here: ARM-software/acle#292
pratlucas
added a commit
to llvm/llvm-project
that referenced
this pull request
Feb 1, 2024
This updates clang's target defines to include the ACLE changes covering the FEAT_PAuth_LR architecture extension. The changes include: * The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when FEAT_PAuth_LR is available in the target. * A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro, indicating the use of PC as a diversifier for Pointer Authentication (from -mbranch-protection=pac-ret+pc). The approved changes to the ACLE spec can be found here: ARM-software/acle#292
carlosgalvezp
pushed a commit
to carlosgalvezp/llvm-project
that referenced
this pull request
Feb 1, 2024
This updates clang's target defines to include the ACLE changes covering the FEAT_PAuth_LR architecture extension. The changes include: * The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when FEAT_PAuth_LR is available in the target. * A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro, indicating the use of PC as a diversifier for Pointer Authentication (from -mbranch-protection=pac-ret+pc). The approved changes to the ACLE spec can be found here: ARM-software/acle#292
agozillon
pushed a commit
to agozillon/llvm-project
that referenced
this pull request
Feb 5, 2024
This updates clang's target defines to include the ACLE changes covering the FEAT_PAuth_LR architecture extension. The changes include: * The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when FEAT_PAuth_LR is available in the target. * A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro, indicating the use of PC as a diversifier for Pointer Authentication (from -mbranch-protection=pac-ret+pc). The approved changes to the ACLE spec can be found here: ARM-software/acle#292
hassnaaHamdi
pushed a commit
to hassnaaHamdi/ACLE
that referenced
this pull request
Mar 11, 2024
* Add ACLE macros for FEAT_PAuth_LR The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement to the Pointer Authentication extension where the value of PC is used as a diversifier when signing pointers. This updates the ACLE to support the extension by the introduction of a new feature macro and the addition of a new possible value to the existing `__ARM_FEATURE_PAC_DEFAULT` macro.
| @@ -362,6 +362,11 @@ Armv8.4-A [[ARMARMv84]](#ARMARMv84). Support is added for the Dot Product intrin | |||
| * Added description of SVE reinterpret intrinsics. | |||
| * Changes for [Function Multi Versioning](#function-multi-versioning): | |||
| * Added [MOPS](#memcpy-family-of-operations-intrinsics---mops). | |||
| * Introduced the `__ARM_FEATURE_PAUTH_LR` feature macro in section | |||
| [Pointer Authentication](#pointer-authentication) to indicate target support | |||
| for the Armv9.5-A's PAC Enhancements. | |||
There was a problem hiding this comment.
Armv9.5-A's PAC
Remove the possessive apostrophe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement
to the Pointer Authentication extension where the value of PC is used as
a diversifier when signing pointers.
This updates the ACLE to support the extension by the introduction of a
new feature macro and the addition of a new possible value to the
existing
__ARM_FEATURE_PAC_DEFAULTmacro.