IVGCVSW-5846 Remove TODO statements from Armnn Code

 * Removed all instances of TODO statements from comments
 * Removed statements are noted as part of IVGCVSW-5846
 * Removed ProtoxtFixture.cpp from the Onnx Parser tests as it's not used

Signed-off-by: David Monahan <david.monahan@arm.com>
Change-Id: Ia0a15f8a0d4123c8831638634eaa0d1018c40e2c

CMakeLists.txt

@@ -761,7 +761,6 @@ if(BUILD_UNIT_TESTS)
             src/armnnOnnxParser/test/OnnxParserTestUtils.cpp
             src/armnnOnnxParser/test/OnnxParserTestUtils.hpp
             src/armnnOnnxParser/test/Pooling.cpp
-            src/armnnOnnxParser/test/ProtoxtFixture.cpp
             src/armnnOnnxParser/test/Relu.cpp
             src/armnnOnnxParser/test/Reshape.cpp
             src/armnnOnnxParser/test/Shape.cpp

shim/sl/canonical/ArmnnPreparedModel.cpp

@@ -232,7 +232,6 @@ ErrorStatus ArmnnPreparedModel::PrepareMemoryForOutputs(
             return ErrorStatus::OUTPUT_INSUFFICIENT_SIZE;
         }
 
-        //TODO: Need to check for Request::Argument::LifeTime::POINTER
         if (outputArg.lifetime == Request::Argument::LifeTime::POOL)
         {
             size_t bufferSize = memPools.at(outputArg.location.poolIndex).getSize();
@@ -599,7 +598,6 @@ GeneralResult<SharedExecution> ArmnnPreparedModel::createReusableExecution(
 
 GeneralResult<SharedBurst> ArmnnPreparedModel::configureExecutionBurst() const
 {
-    // TODO: Implement BURST
     return nullptr;
 }
 

shim/sl/canonical/CanonicalUtils.cpp

@@ -497,7 +497,7 @@ bool IsDynamicTensor(const armnn::TensorInfo& tensorInfo)
     return !tensorInfo.GetShape().AreAllDimensionsSpecified();
 }
 
-bool AreDynamicTensorsSupported() //TODO
+bool AreDynamicTensorsSupported() 
 {
     return true;
 }

src/armnn/test/ConstTensorLayerVisitor.cpp

@@ -950,7 +950,6 @@ TEST_CASE("CheckNamedLstmLayerCifgDisabled")
     layer->ExecuteStrategy(visitor);
 }
 
-// TODO add one with peephole
 TEST_CASE("CheckLstmLayerPeephole")
 {
     LstmDescriptor descriptor;
@@ -1275,7 +1274,6 @@ TEST_CASE("CheckNamedLstmLayerPeephole")
     layer->ExecuteStrategy(visitor);
 }
 
-// TODO add one with projection
 TEST_CASE("CheckLstmLayerProjection")
 {
     LstmDescriptor descriptor;

src/armnnOnnxParser/OnnxParser.cpp

@@ -1528,8 +1528,7 @@ void OnnxParserImpl::ParseAdd(const onnx::NodeProto& node)
 
     VALID_INPUTS(node, STR_LIST(onnx::TensorProto::FLOAT));
 
-    // TODO: unify broadcast validation code across layers
-    // tracked by: IVGCVSW-1576
+    // IVGCVSW-1576: unify broadcast validation code across layers
 
     // Checking broadcast compatibility : only scalar or 1D tensors
     auto inputs = AddPrepareBroadcast(node.input(0), node.input(1));
@@ -1858,8 +1857,6 @@ void OnnxParserImpl::ParseConv(const onnx::NodeProto& node)
         }
         else
         {
-            // TODO: split the input by channels into channels/groups separate convolutions
-            //  and concatenate the results afterwards
             throw ParseException(fmt::format("Error parsing Convolution node: {}. "
                                              "The 'group'={} parameter should be 1 or be equal to the "
                                              "channel of the input shape={} (in NCHW format). {}",

src/backends/backendsCommon/WorkloadFactory.cpp

@@ -1561,7 +1561,6 @@ bool IWorkloadFactory::IsLayerSupported(const IConnectableLayer& connectableLaye
     return IsLayerConfigurationSupported(layer->GetBackendId(), connectableLayer, dataType, outReasonIfUnsupported);
 }
 
-// TODO merge with defaulted modelOptions above
 bool IWorkloadFactory::IsLayerSupported(const IConnectableLayer& connectableLayer,
                                         Optional<DataType> dataType,
                                         std::string& outReasonIfUnsupported,

src/backends/cl/test/ClRuntimeTests.cpp

@@ -138,7 +138,7 @@ TEST_CASE("RuntimeMemoryUsage")
     CHECK(leakedBefore == leakedAfter);
 
     // Add resonable threshold after and before running valgrind with the ACL clear cache function.
-    // TODO Threshold set to 80k until the root cause of the memory leakage is found and fixed. Revert threshold
+    // Threshold set to 80k until the root cause of the memory leakage is found and fixed. Revert threshold
     // value to 1024 when fixed.
     CHECK(static_cast<long>(reachableAfter) - static_cast<long>(reachableBefore) < 81920);
 

src/timelineDecoder/JSONTimelineDecoder.cpp

@@ -74,9 +74,6 @@ JSONTimelineDecoder::TimelineStatus JSONTimelineDecoder::CreateRelationship(cons
     }
     else
     {
-        /*
-         * TODO Handle DataLink
-         */
         m_Model.relationships.insert({relationship.m_Guid, relationship});
     }
 
@@ -99,9 +96,6 @@ void JSONTimelineDecoder::HandleExecutionLink(const ITimelineDecoder::Relationsh
     }
     else
     {
-        /*
-         * TODO Add some protection against packet ordering issues
-         */
         m_Model.relationships.insert({relationship.m_Guid, relationship});
     }
 }
@@ -128,16 +122,10 @@ void JSONTimelineDecoder::HandleLabelLink(const ITimelineDecoder::Relationship&
         }
         else
         {
-            /*
-             * TODO Add some protection against packet ordering issues
-             */
             m_Model.relationships.insert({relationship.m_Guid, relationship});
         }
     } else
     {
-        /*
-         * TODO Add some protection against packet ordering issues
-         */
         m_Model.relationships.insert({relationship.m_Guid, relationship});
     }
 }
@@ -156,9 +144,6 @@ void JSONTimelineDecoder::HandleTypeLabel(const ITimelineDecoder::Relationship&
     }
     else
     {
-        /*
-        * TODO Add some protection against packet ordering issues
-        */
         m_Model.relationships.insert({relationship.m_Guid, relationship});
     }
 }
@@ -174,9 +159,6 @@ void JSONTimelineDecoder::HandleNameLabel(const ITimelineDecoder::Relationship&
     }
     else
     {
-        /*
-        * TODO Add some protection against packet ordering issues
-        */
         m_Model.relationships.insert({relationship.m_Guid, relationship});
     }
 }
@@ -192,9 +174,6 @@ void JSONTimelineDecoder::HandleBackendIdLabel(const ITimelineDecoder::Relations
     }
     else
     {
-        /*
-        * TODO Add some protection against packet ordering issues
-        */
         m_Model.relationships.insert({relationship.m_Guid, relationship});
     }
 }
@@ -210,9 +189,6 @@ void JSONTimelineDecoder::HandleConnectionLabel(const ITimelineDecoder::Relation
     }
     else
     {
-        /*
-        * TODO Add some protection against packet ordering issues
-        */
         m_Model.relationships.insert({relationship.m_Guid, relationship});
     }
 }
@@ -230,9 +206,6 @@ void JSONTimelineDecoder::HandleRetentionLink(const ITimelineDecoder::Relationsh
     }
     else
     {
-        /*
-        * TODO Add some protection against packet ordering issues
-        */
         m_Model.relationships.insert({relationship.m_Guid, relationship});
     }
 }