Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate cgroups_run_into has taken effect #687

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

ep1cman
Copy link
Contributor

@ep1cman ep1cman commented May 22, 2024

On some systems this seems to have no effect, leaving the executed shell in the root cgroup. Before, this function would still execute and the end user would think the desired process was run in the cgroup when infact it had not.

On some systems this seems to have no effect, leaving the executed shell in the root cgroup. Before, this function would still execute and the end user would think the desired process was run in the cgroup when infact it had not.
@douglas-raillard-arm
Copy link
Contributor

Not a comment on the goal of this PR but the cgroups module has deep design flaws. I very strongly recommend you update your code to use the cgroups2 module, which among other things provides support for both cgroup v1 and v2 with a unified API (i.e. it's just a parameter, you get support for both with the same client code). It also actually let you build a cgroup hierarchy unlike cgroups that is built around a very narrow use of cgroups with a poor quality implementation (e..g it leaks grep patterns in the Python API, making maintenance problematic)

Copy link
Collaborator

@marcbonnici marcbonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, as Douglas mentioned it might be worth migrating to the updated module if you can, however this LGTM to help other users of this implementation.

@marcbonnici marcbonnici merged commit c9b539f into ARM-software:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants