Custom rtapp support - now supports multiple styles of links #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derkling
reviewed
Sep 20, 2016
libs/wlgen/wlgen/rta.py
Outdated
| kind='custom', | ||
| duration=-1, | ||
| params={ | ||
| 'custom_config'= { ...my description of the rt-app job... } |
There was a problem hiding this comment.
Maybe you already considered that, isn't possible to avoid introducing a nested dictionary and just check the value of params?
if ininstace(self.params['custom'], str):
# we have the filename for a JSON configuraiton
elif ininstace(self.params['custom'], dict):
# we have an embedded dictionary-cased configuration
else:
raise ValueError("params can be only a filename or an embedded dictionary")There was a problem hiding this comment.
yes, this is possible. I can change this and push an update :)
Allow custom workloads to be defined with a filename or by supplying the configuration directly. Signed-off-by: Chris Redpath <chris.redpath@arm.com>
credp
force-pushed
the
custom_rtapp_v5
branch
from
6cc62fa
to
2a6eb00
Compare
Create a simulated 'performance benchmark application' using RTA which has one controller thread which triggers a configurable amount of worker threads for a configurable amount of time. This is similar to what applications like geekbench look like during their benchmark phases. Signed-off-by: Chris Redpath <chris.redpath@arm.com>
credp
force-pushed
the
custom_rtapp_v5
branch
from
2a6eb00
to
2097f31
Compare
|
@credp Could we revive this or is it no longer relevant ? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to pass a dictionary in with the configuration, and also to reference a file.