Fix TestEnv.calibration() #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why two commits? I think the first one is not necessary. |
|
Well it's doing two different things really:
The code change would look OK as a single commit but I think they're distinct behavioural changes. |
|
But you are removing that line in the following commit... |
|
Yeah, and if it was only one commit then I would be moving and changing it in the same commit, which would be confusing, no? |
|
The 2 commits make sense to me - as @bjackman says, the first is a change and the second is a move. That way the history reads like "I'm changing this. Now I'm moving this" rather than "I'm moving this. By the way, I'm also changing this but you really have to look at what is being changed to notice." |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.