Mass storage assert fixes #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In USBD_MSC_MemoryWrite if Offset and BulkLen are both 0 then then there is an integer underflow and an assert is falsely triggered. This patch corrects that logic so the assert is is only triggered if there would have been a buffer overflow. Prior to this patch this assert would occur during a write if the media state changes to not ready after the CBW has been read but before any data has been transferred.
Assert that bulk out is halted when handling an unexpected out packet when waiting to send the CSW. If this endpoint is halted then the packet is leftover from the previous transaction.
|
@mbed-bot: TEST |
This was referenced Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct asserts that were triggering incorrectly.