ADD SSCI TY51822r3 target #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
toyowata
commented
Feb 10, 2016
toyowata
commented
- Add Switch Science mbed TY51822r3 target
- LPC11U35 interface refactor
- Change SW_RESET_BUTTON port (it should also work with SWDAP since BL and ISP signal is shorted)
- Remove unused functions and variables
- gpio_get_sw_reset() now uses Port In register to read signal level which wrongly used W register
* Add Switch Science mbed TY51822r3 target * LPC11U35 interface refactor - Change SW_RESET_BUTTON port (it should work with DIPDAP since BL and ISP signal is shorted) - Remove unused functions and variables - gpio_get_sw_reset() now uses Port In register to read signal level which wrongly used W register.
| #define RESET_PORT (0) | ||
| #define RESET_PIN (1) | ||
| #define RESET_PORT (1) | ||
| #define RESET_PIN (19) |
There was a problem hiding this comment.
Why did the reset pin change to 19?
Because mbed HDK reference schematics used P1_19 for bootloader reset and most of platforms based on mbed-HDK, used P1_19 for reset button signal AFAIK. The SWDAP should also work with P1_19 since P1_19 and P0_1 are shorted. |
|
This target was added with #57 and will be merged soon. Will track the reset button as a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.