Split nordic sdk into its own module #75
Conversation
nrf51-sdk git@github.com:ARMmbed/nrf51-sdk.git
as ble-nrf51822 provides implementation for ble
To reflect the deletion of the nordic sdk license.
|
I wonder whether this is a good opportunity to remove the |
|
ble-nrf51822 is also shared with mbed-classic. The mbed-classic toolchain expects to find the bootloader here. |
|
Ah ok, forgot about that |
| @@ -1,9 +1,7 @@ | |||
| Many of the files in this module have been inherited from the Nordic SDK for | |||
| nRF51822. With the exception of the softdevice, they come with a BSD license | |||
| This module contains softdevice which comes with a BSD license | |||
There was a problem hiding this comment.
you've got two sentences here which are both talking about the softdevice license. The softdevice is covered by the Softdevice License Agreement.
|
happy with it in general. |
|
@rgrover please review. |
|
ready for merge. I'll now check if the sources in nrf51-sdk match the files we're losing on ble-nrf51dk. |
|
@rgrover broke ble-examples. hold off merging pending further investigation. |
|
@LiyouZhou IMO, splitting the Nordik SDK to its own module is great ! Should the |
|
Answer here, sorry... https://github.com/ARMmbed/nrf51-sdk/blob/master/README.md#changes-made-to-nordic-files |
Separate concept of minlen and len for BLE chars
nrf51-sdk git@github.com:ARMmbed/nrf51-sdk.git
as ble-nrf51822 provides implementation for ble
To reflect the deletion of the nordic sdk license.
…into split_nordic_sdk Conflicts: module.json
|
@rgrover I have made the fixes required. Please continue reviewing this merge. |
|
this a large collection of deletions, which is what I had expected it to be. is the nrf51-sdk module populated with exactly the same files which have been deleted from here? |
|
@rgrover yes and more files used in other modules. |
|
published ble-nrf51822-2.2.0 |
Remove nordic files from this module and make ble-nrf51822 depend on nrf51-sdk. @rgrover