Fixed endianness bug in nRF5xServiceDiscovery::processDiscoverUUIDResponse so it is consistent with BLE API. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse to be consistent with BLE API.
|
@pan- please comment on this. |
| for (unsigned i = 0; i < UUID::LENGTH_OF_LONG_UUID; i++) { | ||
| uuid[i] = response->handle_value[0].p_value[UUID::LENGTH_OF_LONG_UUID - 1 - i]; | ||
| uuid[i] = response->handle_value[0].p_value[i]; |
There was a problem hiding this comment.
Maybe it is better to use memcpy instead of a for loop
|
@pan- any comments to the PR, not the original code? |
|
I'm not sure to understand, I'm talking about the PR, it can be improved if memcpy is used instead of for loop. |
|
I didn't put in the for-loop. If you want it removed, open an issue or make a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BLE::UUID, uuids are stored and handled little endian. This PR preserves the endianness returned by the Nordic Softdevice during discovery.