Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V10 helper func #97

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

LiyouZhou
Copy link
Contributor

Replace helper functions provided by ble-nrf51822 with ones provided by nordic sdk v10. Depends on ARMmbed/nrf51-sdk#13.

@pan- Please review.

@@ -25,7 +25,7 @@
],
"dependencies": {
"ble": "^2.1.16",
"nrf51-sdk": "^1.0.0"
"nrf51-sdk": "^2.0.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LiyouZhou: There seems to be a conflict with this PR, I think the problem is that the required nordic sdk version has already been updated in develop for this module.

@LiyouZhou
Copy link
Contributor Author

bump

@pan-
Copy link
Member

pan- commented Jan 19, 2016

I didn't forgot about these, it is just that I need time to analyze what is going on on the previous implementation and the new one.
I will close this soon

@ghost
Copy link

ghost commented Feb 16, 2016

how's this gonna go now that there's an nrf52 sdk module?

@ciarmcom
Copy link
Member

Automatic CI verification build not done, please verify manually.

@pan-
Copy link
Member

pan- commented Feb 16, 2016

NRF52 doesn't change anything, the Nordic SDK still exist, softdevice still exist and NRF51 still exist.
Nordic has made a nice work to make SDK v10 and SDK v11 compatible. It should not be an issue.

@ghost
Copy link

ghost commented Feb 16, 2016

sure, but there's a direct dependency on the nrf51 sdk yotta module, but no dependency on the nrf52-sdk yotta module

@pan-
Copy link
Member

pan- commented Feb 16, 2016

The nrf52 port is far from ready at the moment.
Later, I think we will have an nrf-sdk repository which encompass nordic SDK for nrf51 and nrf52. There is no difference between these two. At some point, I also think that this repository (ble-nrf51822) will become ble-nrf5X and will be used by nrf51 and nrf52 platform.

@LiyouZhou
Copy link
Contributor Author

@pan- What is your plan for this?

@pan-
Copy link
Member

pan- commented Feb 22, 2016

I won't merge it now, I need time to understand all the implications of this change. But I did not forget about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants