Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API to facilitate full shutdown procedure #141

Merged
merged 2 commits into from
Dec 16, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions ble/Gap.h
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,54 @@ class Gap {
radioNotificationCallback.attach(tptr, mptr);
}

protected:
/**
* Clear all Gap state of the associated object.
*
* This function is meant to be overridden in the platform-specific
* sub-class. Nevertheless, the sub-class is only expected to clean up its
* state and not the data held in Gap members. This shall be achieved by a
* call to Gap::cleanup() from the sub-class' cleanup() implementation.
*
* @return BLE_ERROR_NONE on success.
*
* @note: Currently a call to cleanup() does not reset the advertising and
* scan parameters to default values.
*/
virtual ble_error_t cleanup(void) {
/* Clear Gap state */
state.advertising = 0;
state.connected = 0;

/* Clear scanning state */
scanningActive = false;

/* Clear advertising and scanning data */
_advPayload.clear();
_scanResponse.clear();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the callback states also be reset? similar to what you've done for GattClient.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I missed this ones. They should also be cleared.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it would be interesting to call clearAdvertisingPayload and clearScanResponse, it seems that these functions does more things.

return BLE_ERROR_NONE;
}

public:
/**
* Clear all Gap state of the object pointed to by gapInstance.
*
* This function is meant to be called by the overridden BLE::shutdown()
* in the platform-specific sub-class.
*
* @return BLE_ERROR_NONE on success.
*
* @note: If gapInstance is NULL then it is assumed that Gap has not been
* instantiated and a call to Gap::shutdown() will succeed.
*/
static ble_error_t shutdown(void) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is only meant to be called by BLE::shutdown, then perhaps it should remain private; and we can make BLE::shutdown() a friend.

if (gapInstance) {
return gapInstance->cleanup();
}
return BLE_ERROR_NONE;
}

protected:
Gap() :
_advParams(),
Expand Down Expand Up @@ -1051,6 +1099,10 @@ class Gap {
GapState_t state;
bool scanningActive;

protected:
static Gap *gapInstance; /**< Pointer to the Gap object instance.
* If NULL, then Gap has not been initialized. */

protected:
TimeoutEventCallbackChain_t timeoutCallbackChain;
RadioNotificationEventCallback_t radioNotificationCallback;
Expand Down
44 changes: 44 additions & 0 deletions ble/GattClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,46 @@ class GattClient {
return onHVXCallbackChain;
}

protected:
/**
* Clear all GattClient state of the associated object.
*
* This function is meant to be overridden in the platform-specific
* sub-class. Nevertheless, the sub-class is only expected to clean up its
* state and not the data held in GattClient members. This shall be achieved
* by a call to GattClient::cleanup() from the sub-class' cleanup()
* implementation.
*
* @return BLE_ERROR_NONE on success.
*/
virtual ble_error_t cleanup(void) {
onDataReadCallbackChain.clear();
onDataWriteCallbackChain.clear();
onHVXCallbackChain.clear();

return BLE_ERROR_NONE;
}

public:
/**
* Clear all GattClient state of the object pointed to by
* gattClientInstance.
*
* This function is meant to be called by the overridden BLE::shutdown()
* in the platform-specific sub-class.
*
* @return BLE_ERROR_NONE on success.
*
* @note: If gattClientInstance is NULL then it is assumed that Gap has not
* been instantiated and a call to GattClient::shutdown() will succeed.
*/
static ble_error_t shutdown(void) {
if (gattClientInstance) {
return gattClientInstance->cleanup();
}
return BLE_ERROR_NONE;
}

protected:
GattClient() {
/* Empty */
Expand All @@ -351,6 +391,10 @@ class GattClient {
WriteCallbackChain_t onDataWriteCallbackChain;
HVXCallbackChain_t onHVXCallbackChain;

protected:
static GattClient *gattClientInstance; /**< Pointer to the GattClient object instance.
* If NULL, then GattClient has not been initialized. */

private:
/* Disallow copy and assignment. */
GattClient(const GattClient &);
Expand Down
50 changes: 50 additions & 0 deletions ble/GattServer.h
Original file line number Diff line number Diff line change
Expand Up @@ -396,10 +396,60 @@ class GattServer {
dataSentCallChain.call(count);
}

protected:
/**
* Clear all GattServer state of the associated object.
*
* This function is meant to be overridden in the platform-specific
* sub-class. Nevertheless, the sub-class is only expected to clean up its
* state and not the data held in GattServer members. This shall be achieved
* by a call to GattServer::cleanup() from the sub-class' cleanup()
* implementation.
*
* @return BLE_ERROR_NONE on success.
*/
virtual ble_error_t cleanup(void) {
serviceCount = 0;
characteristicCount = 0;

dataSentCallChain.clear();
dataWrittenCallChain.clear();
dataReadCallChain.clear();
updatesEnabledCallback = NULL;
updatesDisabledCallback = NULL;
confirmationReceivedCallback = NULL;

return BLE_ERROR_NONE;
}

public:
/**
* Clear all GattServer state of the object pointed to by
* gattServerInstance.
*
* This function is meant to be called by the overridden BLE::shutdown()
* in the platform-specific sub-class.
*
* @return BLE_ERROR_NONE on success.
*
* @note: If gattServerInstance is NULL then it is assumed that Gap has not
* been instantiated and a call to GattServer::shutdown() will succeed.
*/
static ble_error_t shutdown(void) {
if (gattServerInstance) {
return gattServerInstance->cleanup();
}
return BLE_ERROR_NONE;
}

protected:
uint8_t serviceCount;
uint8_t characteristicCount;

protected:
static GattServer *gattServerInstance; /**< Pointer to the GattServer object instance.
* If NULL, then GattServer has not been initialized. */

private:
DataSentCallbackChain_t dataSentCallChain;
DataWrittenCallbackChain_t dataWrittenCallChain;
Expand Down
47 changes: 47 additions & 0 deletions ble/SecurityManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,53 @@ class SecurityManager {
/* empty */
}

protected:
/**
* Clear all SecurityManager state of the associated object.
*
* This function is meant to be overridden in the platform-specific
* sub-class. Nevertheless, the sub-class is only expected to clean up its
* state and not the data held in SecurityManager members. This shall be
* achieved by a call to SecurityManager::cleanup() from the sub-class'
* cleanup() implementation.
*
* @return BLE_ERROR_NONE on success.
*/
virtual ble_error_t cleanup(void) {
securitySetupInitiatedCallback = NULL;
securitySetupCompletedCallback = NULL;
linkSecuredCallback = NULL;
securityContextStoredCallback = NULL;
passkeyDisplayCallback = NULL;

return BLE_ERROR_NONE;
}

public:
/**
* Clear all SecurityManager state of the object pointed to by
* securityManagerInstance.
*
* This function is meant to be called by the overridden BLE::shutdown()
* in the platform-specific sub-class.
*
* @return BLE_ERROR_NONE on success.
*
* @note: If securityManagerInstance is NULL then it is assumed that Gap has
* not been instantiated and a call to SecurityManager::shutdown() will
* succeed.
*/
static ble_error_t shutdown(void) {
if (securityManagerInstance) {
return securityManagerInstance->cleanup();
}
return BLE_ERROR_NONE;
}

protected:
static SecurityManager *securityManagerInstance; /**< Pointer to the SecurityManager object instance.
* If NULL, then SecurityManager has not been initialized. */

protected:
SecuritySetupInitiatedCallback_t securitySetupInitiatedCallback;
SecuritySetupCompletedCallback_t securitySetupCompletedCallback;
Expand Down
21 changes: 21 additions & 0 deletions ble/ServiceDiscovery.h
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,27 @@ class ServiceDiscovery {
*/
virtual void onTermination(TerminationCallback_t callback) = 0;

/**
* Clear all ServiceDiscovery state of the associated object.
*
* This function is meant to be overridden in the platform-specific
* sub-class. Nevertheless, the sub-class is only expected to clean up its
* state and not the data held in ServiceDiscovery members. This shall be
* achieved by a call to ServiceDiscovery::cleanup() from the sub-class'
* cleanup() implementation.
*
* @return BLE_ERROR_NONE on success.
*/
virtual ble_error_t cleanup(void) {
connHandle = 0;
matchingServiceUUID = UUID::ShortUUIDBytes_t(BLE_UUID_UNKNOWN);
serviceCallback = NULL;
matchingCharacteristicUUID = UUID::ShortUUIDBytes_t(BLE_UUID_UNKNOWN);
characteristicCallback = NULL;

return BLE_ERROR_NONE;
}

protected:
Gap::Handle_t connHandle; /**< Connection handle as provided by the SoftDevice. */
UUID matchingServiceUUID;
Expand Down
19 changes: 19 additions & 0 deletions source/Gap.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include "ble/Gap.h"

Gap *Gap::gapInstance = NULL;
19 changes: 19 additions & 0 deletions source/GattClient.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include "ble/GattClient.h"

GattClient *GattClient::gattClientInstance = NULL;
19 changes: 19 additions & 0 deletions source/GattServer.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include "ble/GattServer.h"

GattServer *GattServer::gattServerInstance = NULL;
19 changes: 19 additions & 0 deletions source/SecurityManager.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include "ble/SecurityManager.h"

SecurityManager *SecurityManager::securityManagerInstance = NULL;