Remove printf call from interrupt context #31
Conversation
With ARM compiler at least, if we enable DEBUG, the InterruptIn will fail in timeout as the program would crash calling printf in the cbfn as this happens in Interrupt context. Let's remove it
|
@mray19027 be aware of this for the work you are doing. Make sure to test with armcc and gcc and iarcc when validating. @LMESTM what version of armcc are you using? |
| @@ -33,7 +33,6 @@ volatile bool result = false; | |||
| void cbfn(void) | |||
| { | |||
| result = true; | |||
| DEBUG_PRINTF("\t**** Interrupt Triggered!\n"); | |||
|
LGTM I am thinking how we can log from interrupt, use deferred events? @LMESTM Any proposals? |
|
I'll merge this, we should not print anything from interrupt, find another approach for this (buffer serial or deferred events). |
|
This should not have been merged without adding a replacement. The existing printf's were only in debug, now instead of having some debug there is no debug whatsoever for this. I would argue that without a replacement the tests are made worse rather than better. |
If the test fails because of it (in this case timeout), I think its better not to have the debug print (a bad practice to invoke printf in interrupt routines). An issue should have been created. Ill do it right-away. I'll fix it and revert this one ;) |
With ARM compiler at least, if we enable DEBUG, the InterruptIn will fail
in timeout as the program would crash calling printf in the cbfn as this
happens in Interrupt context. Let's remove it