Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename F401 dependency to align with F429. #9

Merged
merged 2 commits into from
Oct 12, 2015

Conversation

markus-becker-tridonic-com
Copy link
Contributor

We do have a working F401 port of mbedOS, which required the renaming of the cmsis-core-st-stm32f401xe to cmsis-core-stm32f401xe. This aligns the yotta module name with F429, which is released.

The additional modules and targets are
https://github.com/markus-becker-tridonic-com/cmsis-core-stm32f401xe
https://github.com/markus-becker-tridonic-com/mbed-hal-st-stm32f401re
https://github.com/markus-becker-tridonic-com/st-nucleo-f401re-gcc

Would be great if those could be upstreamed as well.

@sg-
Copy link

sg- commented Sep 16, 2015

This is a great start but I think there is some confusion about where seperation is between a mcu and board. I think we may need some more documentation on how to do this before accepting this PR.

Specifically see https://github.com/markus-becker-tridonic-com/mbed-hal-st-stm32f401re where board pin names are part of a mcu-hal. This makes modular reuse difficult.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 16, 2015

A good catch, I'll add here a tree for k64f as illustration:

example-mbedos-blinky 0.0.0
|_ mbed-drivers 0.6.8
| |_ mbed-hal 0.6.2 yotta_modules\mbed-hal
| | |_ mbed-drivers *
| | \_ mbed-hal-freescale 0.5.2 yotta_modules\mbed-hal-freescale
| |   \_ mbed-hal-ksdk-mcu 0.5.4 yotta_modules\mbed-hal-ksdk-mcu
| |     |_ mbed-hal *
| |     |_ uvisor-lib >=0.7.0,<0.8.0
| |     \_ mbed-hal-k64f 0.3.5 yotta_modules\mbed-hal-k64f
| |       |_ mbed-hal *
| |       \_ mbed-hal-frdm-k64f 0.4.3 yotta_modules\mbed-hal-frdm-k64f
| |         \_ mbed-hal >=0.6.0,<0.7.0

@sg- we should look again at ARMmbed/mbed-hal#7 (touches also naming as mentioned above by @markus-becker-tridonic-com )

@markus-becker-tridonic-com
Copy link
Contributor Author

We modelled this how F429 in beta is doing it. The alpha of F401 was doing it differently (probably more correctly). Will you change F429? Will you take the F401 from alpha?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2015

@markus-becker-tridonic-com PR looks good, although don't change version tag, that one will be updated once merged. We are currently removing cmsis_nvic, there should be soon a new update of cmsis-core to reflect it.

What @sg- pointed out above, it's related to HAL, this is PR regarding cmsis, which seems to be fine.

@markus-becker-tridonic-com
Copy link
Contributor Author

Updated, to resolve the conflict of the version number.

@markus-becker-tridonic-com
Copy link
Contributor Author

@0xc0170 would you merge this updated PR?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 8, 2015

I don't see this module published in yotta registry (http://yotta.mbed.com/#search/cmsis-core-stm32f401xe) ?

@markus-becker-tridonic-com
Copy link
Contributor Author

The module is mentioned in the first post of this thread. Would be good if the additional modules could be merged into ARMmbed.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 8, 2015

I am getting this error: error: cmsis-core-stm32f401xe does not exist in the modules registry. Check that the name is correct, and that it has been published. (I am not locally linking, thus my question above about publishing this module)

@markus-becker-tridonic-com
Copy link
Contributor Author

You are right, this module is not there yet. We have created it and would be happy to contribute it as stated in the first comment.

For your reference:
https://github.com/markus-becker-tridonic-com/cmsis-core-stm32f401xe
https://github.com/markus-becker-tridonic-com/mbed-hal-st-stm32f401re
https://github.com/markus-becker-tridonic-com/st-nucleo-f401re-gcc

0xc0170 added a commit that referenced this pull request Oct 12, 2015
Rename F401 dependency to align with F429.
@0xc0170 0xc0170 merged commit 463c9d7 into ARMmbed:master Oct 12, 2015
winfred-lu referenced this pull request in ARMmbed/mbed-hal-st-stm32f4 Oct 20, 2015
The STM32F429 and the STM32F439 are nearly identical
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants