-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename F401 dependency to align with F429. #9
Conversation
This is a great start but I think there is some confusion about where seperation is between a mcu and board. I think we may need some more documentation on how to do this before accepting this PR. Specifically see https://github.com/markus-becker-tridonic-com/mbed-hal-st-stm32f401re where board pin names are part of a mcu-hal. This makes modular reuse difficult. |
A good catch, I'll add here a tree for k64f as illustration:
@sg- we should look again at ARMmbed/mbed-hal#7 (touches also naming as mentioned above by @markus-becker-tridonic-com ) |
We modelled this how F429 in beta is doing it. The alpha of F401 was doing it differently (probably more correctly). Will you change F429? Will you take the F401 from alpha? |
@markus-becker-tridonic-com PR looks good, although don't change version tag, that one will be updated once merged. We are currently removing cmsis_nvic, there should be soon a new update of cmsis-core to reflect it. What @sg- pointed out above, it's related to HAL, this is PR regarding cmsis, which seems to be fine. |
…odule Conflicts: module.json
Updated, to resolve the conflict of the version number. |
@0xc0170 would you merge this updated PR? |
I don't see this module published in yotta registry (http://yotta.mbed.com/#search/cmsis-core-stm32f401xe) ? |
The module is mentioned in the first post of this thread. Would be good if the additional modules could be merged into ARMmbed. |
I am getting this error: error: cmsis-core-stm32f401xe does not exist in the modules registry. Check that the name is correct, and that it has been published. (I am not locally linking, thus my question above about publishing this module) |
You are right, this module is not there yet. We have created it and would be happy to contribute it as stated in the first comment. For your reference: |
Rename F401 dependency to align with F429.
The STM32F429 and the STM32F439 are nearly identical
We do have a working F401 port of mbedOS, which required the renaming of the cmsis-core-st-stm32f401xe to cmsis-core-stm32f401xe. This aligns the yotta module name with F429, which is released.
The additional modules and targets are
https://github.com/markus-becker-tridonic-com/cmsis-core-stm32f401xe
https://github.com/markus-becker-tridonic-com/mbed-hal-st-stm32f401re
https://github.com/markus-becker-tridonic-com/st-nucleo-f401re-gcc
Would be great if those could be upstreamed as well.