Skip to content
This repository has been archived by the owner on Apr 24, 2019. It is now read-only.

Removed usage of SW2 / SW3 #55

Closed
wants to merge 2 commits into from
Closed

Removed usage of SW2 / SW3 #55

wants to merge 2 commits into from

Conversation

MarceloSalazar
Copy link
Contributor

As we need to make the example a bit more generic to work with multiple targets that do not have push buttons, then the proposed solution is to remove the SW3 that was responsible for the unregistration and replace SW2 by a periodic timer.

As we need to make the example a bit more generic to work with
multiple targets that do not have push buttons, then the proposed
solution is to remove the SW3 that was responsible for the
unregistration and replace SW2 by a periodic timer.
@MarceloSalazar
Copy link
Contributor Author

MarceloSalazar commented Jul 30, 2016

@sg- @yogpan01

Please have a look to this proposal to make the application generic to work with multiple targets.
I would have preferred to keep the code that use SW2 / SW3 for those targets that have the switches, but it seems usage of #ifdef is not allowed with enums (e.g. SW2).
You may think of a different solution.

@yogpan01
Copy link
Contributor

yogpan01 commented Aug 1, 2016

@MarceloSalazar Fix proposed here #57

@yogpan01
Copy link
Contributor

yogpan01 commented Aug 1, 2016

Fixed through other PR #57

@yogpan01 yogpan01 closed this Aug 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants