New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the server to os.mbed.com #115
Conversation
Thanks for the PR. I think the changes look good and I already checked that the server certificate still checks out with the PEM CA in the tls-client program. Currently just waiting for the CI to give us a pass. |
tls-client/main.cpp
Outdated
@@ -50,7 +50,7 @@ | |||
|
|||
namespace { | |||
|
|||
const char *HTTPS_SERVER_NAME = "developer.mbed.org"; | |||
const char *HTTPS_SERVER_NAME = "os.mbed.org"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, it seems that the domain should actually be os.mbed.com
. I tried os.mbed.org
and that says the site is unreachable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops my bad , updated the PR.
Corrected typo, Output of test run below.
|
@studavekar: Thank you for the fix. I will wait for the CI results. |
Hi @studavekar
When changed to os.mbed.com the output should be:
with the HTTPS response |
@RonEld: According to the CI logs, the correct HTTPS response with the "Hello world!" message are being received correctly. |
Closing this PR as #117 contains these changes and many other references to developer.mbed.org that needed to be updated to os.mbed.com |
Related :
ARMmbed/mbed-os#5122