Skip to content

Commit

Permalink
Fix detection of supported targets for mbed 2 builds
Browse files Browse the repository at this point in the history
  • Loading branch information
bridadan committed Apr 8, 2019
1 parent 801e555 commit 8a2836f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
4 changes: 1 addition & 3 deletions tools/build.py
Expand Up @@ -182,9 +182,8 @@ def main():
except NoValidToolchainException as e:
print_end_warnings(e.end_warnings)
args_error(parser, str(e))

tt_id = "%s::%s" % (internal_tc_name, target_name)
if not target_supports_toolchain(target, toolchain):
if not target_supports_toolchain(target, toolchain_name):
# Log this later
print("%s skipped: toolchain not supported" % tt_id)
skipped.append(tt_id)
Expand All @@ -196,7 +195,6 @@ def main():
if target.is_PSA_secure_target and \
not is_relative_to_root(options.source_dir):
options.source_dir = ROOT

if options.source_dir:
lib_build_res = build_library(
options.source_dir, options.build_dir, target, toolchain_name,
Expand Down
9 changes: 5 additions & 4 deletions tools/build_api.py
Expand Up @@ -988,7 +988,6 @@ def build_mbed_libs(target, toolchain_name, clean=False, macros=None,
#then set the default_toolchain to uARM to link AC6 microlib.
if(selected_toolchain_name == "ARMC6" and toolchain_name == "uARM"):
target.default_toolchain = "uARM"
toolchain_name = selected_toolchain_name

if report is not None:
start = time()
Expand All @@ -1003,7 +1002,7 @@ def build_mbed_libs(target, toolchain_name, clean=False, macros=None,
prep_properties(
properties, target.name, toolchain_name, vendor_label)

if toolchain_name not in target.supported_toolchains:
if not target_supports_toolchain(target, toolchain_name):
supported_toolchains_text = ", ".join(target.supported_toolchains)
notify.info('The target {} does not support the toolchain {}'.format(
target.name,
Expand All @@ -1023,14 +1022,16 @@ def build_mbed_libs(target, toolchain_name, clean=False, macros=None,

try:
# Source and Build Paths

build_toolchain = join(
MBED_LIBRARIES, mbed2_obj_path(target.name, toolchain_name))
MBED_LIBRARIES, mbed2_obj_path(target.name, selected_toolchain_name)
)
mkdir(build_toolchain)

tmp_path = join(
MBED_LIBRARIES,
'.temp',
mbed2_obj_path(target.name, toolchain_name)
mbed2_obj_path(target.name, selected_toolchain_name)
)
mkdir(tmp_path)

Expand Down

0 comments on commit 8a2836f

Please sign in to comment.