-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvstore-general_tests_phase_1 fails on CY8CPROTO_062_4343W after #11918 #12031
Comments
Internal Jira reference: https://jira.arm.com/browse/MBOTRIAGE-2451 |
cc @ARMmbed/mbed-os-storage |
That piece of code is last changed a year ago. |
I can replicate the issue with current Mbed OS master. I'll continue to investigate. |
-2130771685 & 0xffff = 283 which is error: |
I looked into this a bit today I believe the problem is that the new sizes are too small - they may not span two erase sectors. For example, in the external flash on CY8CPROTO_062_4343W, the erase size is 0x40000 and the program size is 0x200 - so program_size * 40 = 0x5000 which gets aligned up to exactly one erase sector. The "Read failed" is reported because it is trying to read past the end of the second area, whose size in TDBStore::_area_params is computed as 0. ul_bd_size = align_up(program_size * 40, erase_size * 2);
rbp_bd_size = align_up(program_size * 40, erase_size * 2); |
@kyle-cypress Thanks, that seems to be the root cause. That fixed the CY8PROTO. I'll just verify with K64F and send a patch if it does not cause regression. |
Description of defect
SEC_kvstore_init fails in features-storage-tests-kvstore-general_tests_phase_1 on CY8CPROTO_062_4343W (and possibly other Cypress targets as well; those have not been tested yet).
A bisect narrowed the culprit to the test updates in abbb248 (merged as part of #11918). If that commit is reverted the tests all pass.
Further experimentation narrowed the cause specifically to the following portion of the patch:
Target(s) affected by this defect ?
CY8CPROTO_062_4343W (possibly others as well).
Toolchain(s) (name and version) displaying this defect ?
GCC_ARM 6.3.1
What version of Mbed-os are you using (tag or sha) ?
9248169
What version(s) of tools are you using. List all that apply (E.g. mbed-cli)
mbed-cli version 1.10.1
How is this defect reproduced ?
Run features-storage-tests-kvstore-general_tests_phase_1 on CY8CPROTO_062_4343W
Relevant log snippet with verbose mode (
mbed test -vv
) enabled:The text was updated successfully, but these errors were encountered: