Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TDBStore sizes for SecureStore tests #12050

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

SeppoTakalo
Copy link
Contributor

Summary of changes

Tests must require at least 2 erase sectors per TDBStore,
so that the garbage collection may work.

Fixes #12031


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Tests must require at least 2 erase sectors per TDBStore,
so that the garbage collection may work.
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2019

@SeppoTakalo I set this to 5.15rc2 (as PR #11918 is in that release as well causing the issue referenced and fixed here).

@0xc0170 0xc0170 requested a review from a team December 9, 2019 09:26
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2019

CI started

@SeppoTakalo
Copy link
Contributor Author

This cannot be applied to 5.15 branch. Base file is different.

Some changes have been marked as feature changes and therefore did not go into 5.15 branch.
I need to provide separate patch for 5.15.

@SeppoTakalo
Copy link
Contributor Author

Actually, this applies cleanly if 0fe159f is also applied to 5.15 before this one.

@SeppoTakalo
Copy link
Contributor Author

@0xc0170 and @adbridge Please note, for 5.15 you need to cherry-pick
0fe159f
before applying this patch.

The mentioned patch was part of bigger PR that cannot be brought into 5.15 fully, so just apply that one commit from there.

@adbridge
Copy link
Contributor

adbridge commented Dec 9, 2019

@0xc0170 this is only a change to tests why have you tagged Cypress for review ?

@SeppoTakalo
Copy link
Contributor Author

@adbridge
Original issue was reported by Cypress on one of their board.

@SeppoTakalo SeppoTakalo requested review from VeijoPesonen and a team and removed request for VeijoPesonen December 9, 2019 11:21
Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mbed-ci
Copy link

mbed-ci commented Dec 9, 2019

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2019

Removed the release label, there is #12056 that will go to the release 5.15 branch

@SeppoTakalo SeppoTakalo deleted the IOTSTOR-992 branch December 10, 2019 09:37
@SeppoTakalo
Copy link
Contributor Author

@0xc0170 both should be included in the 5.15.

The #12056 fixes one test, and is required so that this PR can be applied cleanly.

@adbridge
Copy link
Contributor

adbridge commented Dec 12, 2019

@SeppoTakalo are you saying that this PR also should go to 5.15 as well as #12056 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvstore-general_tests_phase_1 fails on CY8CPROTO_062_4343W after #11918
5 participants