-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TDBStore sizes for SecureStore tests #12050
Conversation
Tests must require at least 2 erase sectors per TDBStore, so that the garbage collection may work.
@SeppoTakalo I set this to 5.15rc2 (as PR #11918 is in that release as well causing the issue referenced and fixed here). |
CI started |
This cannot be applied to 5.15 branch. Base file is different. Some changes have been marked as feature changes and therefore did not go into 5.15 branch. |
Actually, this applies cleanly if 0fe159f is also applied to 5.15 before this one. |
@0xc0170 this is only a change to tests why have you tagged Cypress for review ? |
@adbridge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Test run: FAILEDSummary: 1 of 5 test jobs failed Failed test jobs:
|
Removed the release label, there is #12056 that will go to the release 5.15 branch |
@SeppoTakalo are you saying that this PR also should go to 5.15 as well as #12056 ? |
Summary of changes
Tests must require at least 2 erase sectors per TDBStore,
so that the garbage collection may work.
Fixes #12031
Pull request type
Test results