Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greentea-client "metrics" API is unused #14790

Closed
Patater opened this issue Jun 17, 2021 · 0 comments · Fixed by #14914
Closed

greentea-client "metrics" API is unused #14790

Patater opened this issue Jun 17, 2021 · 0 comments · Fixed by #14914

Comments

@Patater
Copy link
Contributor

Patater commented Jun 17, 2021

Description of defect

There is some unused code in greentea-client. The API declared in features/frameworks/greentea-client/greentea-client/greentea_metrics.h is not used anywhere. We should deprecate the greentea metrics API.

Add MBED_DEPRECATED to greentea_metrics_setup(), greentea_metrics_report() functions. We should also update the mbed-os-5-docs repo to remove any mention of greentea metrics.

Target(s) affected by this defect ?

All

Toolchain(s) (name and version) displaying this defect ?

All

What version of Mbed-os are you using (tag or sha) ?

mbed-os-99.99.99
3cf5f8e

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

Mbed CLI 2

How is this defect reproduced ?

Grep for greentea_metrics_setup() in our ARMmbed repos and find only implementation, but not use.

@mbedmain mbedmain added this to Needs Triage in Issue Workflow Jun 17, 2021
@mbedmain mbedmain added this to Untriaged in Issue Severity Jun 17, 2021
@Patater Patater added this to Inbox in Mbed Core via automation Jun 17, 2021
@Patater Patater moved this from Inbox to To do (16) in Mbed Core Jun 17, 2021
@Patater Patater moved this from Needs Triage to Open in Issue Workflow Jun 17, 2021
@Patater Patater moved this from Untriaged to Other in Issue Severity Jun 17, 2021
nicole-osaz added a commit to nicole-osaz/mbed-os that referenced this issue Jul 12, 2021
Add the deprecated macro to where the Greentea metrics API is declared.

Fixes ARMmbed#14790
@Patater Patater moved this from To do (16) to Review in progress (4) in Mbed Core Jul 13, 2021
@Patater Patater moved this from Review in progress (4) to Reviewer approved & awaiting CI & merge (3) in Mbed Core Jul 13, 2021
nicole-osaz added a commit to nicole-osaz/mbed-os that referenced this issue Jul 14, 2021
Add the deprecated macro to where the Greentea metrics API is defined
and the missing headerfile include (platform/mbed_toolchain.h)

Fixes ARMmbed#14790
Patater pushed a commit to nicole-osaz/mbed-os that referenced this issue Jul 16, 2021
Add the deprecated macro to where the Greentea metrics API is declared.

Fixes ARMmbed#14790
nicole-osaz added a commit to nicole-osaz/mbed-os that referenced this issue Jul 16, 2021
Add the deprecated macro to where the Greentea metrics API has been
declared.

Fixes ARMmbed#14790
e metrics API
Patater pushed a commit to nicole-osaz/mbed-os that referenced this issue Jul 16, 2021
Add the deprecated macro to where the Greentea metrics API is declared.

Fixes ARMmbed#14790
nicole-osaz added a commit to nicole-osaz/mbed-os that referenced this issue Jul 20, 2021
Add the deprecated macro to where the Greentea metrics API is declared.

Fixes ARMmbed#14790
Patater pushed a commit to nicole-osaz/mbed-os that referenced this issue Jul 20, 2021
Add the deprecated macro to where the Greentea metrics API is declared.

Fixes ARMmbed#14790
Mbed Core automation moved this from Reviewer approved & awaiting CI & merge (3) to Done Jul 23, 2021
Issue Workflow automation moved this from Open to Done Jul 23, 2021
@Patater Patater moved this from Done to Reported in Mbed Core Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mbed Core
  
Reported
Development

Successfully merging a pull request may close this issue.

3 participants