Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: AT information response to return false on empty prefix #10084

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

mirelachirica
Copy link
Contributor

Description

AT handler's checks for not defined prefix were incomplete for info resp scope, since they were just NULL checks and _info_resp_prefix is defined as char array so never NULL.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

@ciarmcom ciarmcom requested review from AriParkkila and a team March 13, 2019 18:00
@ciarmcom
Copy link
Member

@mirelachirica, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
Cellular: AT information response to return false on empty prefix
@cmonr cmonr merged commit 6c4b4a5 into ARMmbed:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants