Remove unused tools modules and document the used ones. #10254

theotherjimmy · 2019-03-28T15:08:15Z

Description

These directories have contained exclusively dead code for as long as
I can remember. Now is as good of a time as any to remove them.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

ciarmcom · 2019-03-28T16:00:34Z

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

bridadan · 2019-03-28T16:22:45Z

Pretty sure you can drop the following as well:

theotherjimmy · 2019-03-28T16:24:00Z

@bridadan They're not imported?

bridadan · 2019-03-28T16:26:04Z

@theotherjimmy Nope, just checked

bridadan · 2019-03-28T16:26:41Z

Most of test_webapi.py is commented out 😆

bridadan · 2019-03-28T16:27:10Z

tools/README.md

@@ -45,6 +45,5 @@ Quick navigation:
 | `test_webapi.py`      | part of pre-greentea greentea                  |
 | `tests.py`            | implementation of `mbed test --greentea`       |
 | `toolchains`          | API for calling the selected compiler          |
-| `upload_results.py`   | part of pre-greentea greentea                  |


part of pre-greentea greentea

🤣

cmonr · 2019-03-28T16:39:43Z

tools/README.md

@@ -0,0 +1,48 @@
+# Mbed OS Build Tools


cmonr · 2019-03-28T16:41:40Z

Would like other @ARMmbed/mbed-os-maintainers to chime in, since some of these files have been around longer than I have 😄

bridadan

Love it ❤️

bridadan · 2019-04-01T20:42:39Z

Now you just gotta make travis happy.

theotherjimmy · 2019-04-02T13:49:04Z

Travis is unhappy because data is actually used (or at least 2 constants from it). Turns out they're not really a constant, and not really possible to use, as mbed 2 tests are not supported.

theotherjimmy · 2019-04-02T13:54:08Z

Unit tests now pass.

AnotherButler

Nice work on this 👍

cmonr · 2019-04-02T14:23:43Z

CI started

mbed-ci · 2019-04-02T16:00:28Z

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC5

adbridge

LGTM

0xc0170 · 2019-04-05T15:12:24Z

Oh no, needs quick rebase now, will restart CI then.

jeromecoutant · 2019-04-08T15:33:34Z

Hi
Is #10107 impacted ?

theotherjimmy · 2019-04-08T15:56:53Z

@jeromecoutant I did not remove the Mbed 2 testig framework, so: no this does not affect #10107

### Description These directories have contained exclusively dead code for as long as I can remember. Now is as good of a time as any to remove them. ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change

theotherjimmy · 2019-04-08T15:59:20Z

@0xc0170 Rebased.

cmonr · 2019-04-08T20:25:31Z

CI started

mbed-ci · 2019-04-08T22:27:23Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

theotherjimmy mentioned this pull request Mar 28, 2019

Tools: Mbed OS scripts are not fully python 3 compatible #10249

Closed

theotherjimmy changed the title ~~Remove tools/compliance and tools/dev~~ Remove unused tools modules Mar 28, 2019

ciarmcom requested a review from a team March 28, 2019 16:00

ciarmcom added the needs: review label Mar 28, 2019

theotherjimmy changed the title ~~Remove unused tools modules~~ Remove unused tools modules and document the used ones. Mar 28, 2019

bridadan reviewed Mar 28, 2019

View reviewed changes

cmonr approved these changes Mar 28, 2019

View reviewed changes

tools/README.md

@@ -0,0 +1,48 @@

# Mbed OS Build Tools

Copy link

Contributor

cmonr Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲

cmonr requested a review from a team March 28, 2019 16:41

cmonr added the release-version: 5.13.0-rc1 label Mar 28, 2019

bridadan approved these changes Apr 1, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Apr 2, 2019

cmonr added needs: review needs: CI and removed needs: work needs: review labels Apr 2, 2019

cmonr approved these changes Apr 2, 2019

View reviewed changes

AnotherButler reviewed Apr 2, 2019

View reviewed changes

adbridge approved these changes Apr 5, 2019

View reviewed changes

0xc0170 added needs: work and removed ready for merge labels Apr 5, 2019

theotherjimmy and others added 14 commits April 8, 2019 10:58

Remove unused data python module

1cc311b

Remove empty git_hooks python module

6112a33

Remove unused misc python module

6fa5ca4

Remove unused synch python module

49bd5ed

Remove unused python model: check_release

ed5c6a3

Describe what each python module does

e45beb3

Remove unused size python module

930fb11

Remove unused upload_results python module

3a0eeed

Remove unused test_webapi python module

8ca69e1

Reword table header

96423bd

Remove unused travis build script

a40b273

Remove database code from singletest api

6d754fe

Add the only part of the "data" module that was used

2a4a73c

theotherjimmy force-pushed the remove-some-deadcode branch from 49cf9da to 2a4a73c Compare April 8, 2019 15:59

cmonr added needs: CI and removed needs: work labels Apr 8, 2019

cmonr added ready for merge and removed needs: CI labels Apr 9, 2019

0xc0170 merged commit dc1198b into ARMmbed:master Apr 9, 2019

0xc0170 removed the ready for merge label Apr 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused tools modules and document the used ones. #10254

Remove unused tools modules and document the used ones. #10254

theotherjimmy commented Mar 28, 2019

ciarmcom commented Mar 28, 2019

bridadan commented Mar 28, 2019

theotherjimmy commented Mar 28, 2019

bridadan commented Mar 28, 2019

bridadan commented Mar 28, 2019

bridadan Mar 28, 2019

cmonr Mar 28, 2019

cmonr commented Mar 28, 2019

bridadan left a comment

bridadan commented Apr 1, 2019

theotherjimmy commented Apr 2, 2019 •

edited

theotherjimmy commented Apr 2, 2019

AnotherButler left a comment

cmonr commented Apr 2, 2019

mbed-ci commented Apr 2, 2019

adbridge left a comment

0xc0170 commented Apr 5, 2019

jeromecoutant commented Apr 8, 2019

theotherjimmy commented Apr 8, 2019

theotherjimmy commented Apr 8, 2019

cmonr commented Apr 8, 2019

mbed-ci commented Apr 8, 2019

Remove unused tools modules and document the used ones. #10254

Remove unused tools modules and document the used ones. #10254

Conversation

theotherjimmy commented Mar 28, 2019

Description

Pull request type

ciarmcom commented Mar 28, 2019

bridadan commented Mar 28, 2019

theotherjimmy commented Mar 28, 2019

bridadan commented Mar 28, 2019

bridadan commented Mar 28, 2019

bridadan Mar 28, 2019

Choose a reason for hiding this comment

cmonr Mar 28, 2019

Choose a reason for hiding this comment

cmonr commented Mar 28, 2019

bridadan left a comment

Choose a reason for hiding this comment

bridadan commented Apr 1, 2019

theotherjimmy commented Apr 2, 2019 • edited

theotherjimmy commented Apr 2, 2019

AnotherButler left a comment

Choose a reason for hiding this comment

cmonr commented Apr 2, 2019

mbed-ci commented Apr 2, 2019

Test run: FAILED

adbridge left a comment

Choose a reason for hiding this comment

0xc0170 commented Apr 5, 2019

jeromecoutant commented Apr 8, 2019

theotherjimmy commented Apr 8, 2019

theotherjimmy commented Apr 8, 2019

cmonr commented Apr 8, 2019

mbed-ci commented Apr 8, 2019

Test run: SUCCESS

theotherjimmy commented Apr 2, 2019 •

edited