Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused tools modules and document the used ones. #10254

Merged
merged 14 commits into from Apr 9, 2019

Conversation

Projects
None yet
10 participants
@theotherjimmy
Copy link
Contributor

commented Mar 28, 2019

Description

These directories have contained exclusively dead code for as long as
I can remember. Now is as good of a time as any to remove them.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@theotherjimmy theotherjimmy changed the title Remove tools/compliance and tools/dev Remove unused tools modules Mar 28, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Mar 28, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-tools Mar 28, 2019

@theotherjimmy theotherjimmy changed the title Remove unused tools modules Remove unused tools modules and document the used ones. Mar 28, 2019

@bridadan

This comment has been minimized.

@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

@bridadan They're not imported?

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@theotherjimmy Nope, just checked

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Most of test_webapi.py is commented out 😆

@@ -45,6 +45,5 @@ Quick navigation:
| `test_webapi.py` | part of pre-greentea greentea |
| `tests.py` | implementation of `mbed test --greentea` |
| `toolchains` | API for calling the selected compiler |
| `upload_results.py` | part of pre-greentea greentea |

This comment has been minimized.

Copy link
@bridadan

bridadan Mar 28, 2019

Contributor

part of pre-greentea greentea

🤣

@cmonr

cmonr approved these changes Mar 28, 2019

@@ -0,0 +1,48 @@
# Mbed OS Build Tools

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 28, 2019

Contributor

😲

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Would like other @ARMmbed/mbed-os-maintainers to chime in, since some of these files have been around longer than I have 😄

@cmonr cmonr requested a review from ARMmbed/mbed-os-maintainers Mar 28, 2019

@bridadan
Copy link
Contributor

left a comment

Love it ❤️

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

Now you just gotta make travis happy.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 2, 2019

@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Travis is unhappy because data is actually used (or at least 2 constants from it). Turns out they're not really a constant, and not really possible to use, as mbed 2 tests are not supported.

@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Unit tests now pass.

@cmonr

cmonr approved these changes Apr 2, 2019

@AnotherButler
Copy link
Contributor

left a comment

Nice work on this 👍

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 2, 2019

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC5

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Apr 5, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Oh no, needs quick rebase now, will restart CI then.

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

Hi
Is #10107 impacted ?

@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@jeromecoutant I did not remove the Mbed 2 testig framework, so: no this does not affect #10107

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:remove-some-deadcode branch from 49cf9da to 2a4a73c Apr 8, 2019

@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@0xc0170 Rebased.

@cmonr cmonr added needs: CI and removed needs: work labels Apr 8, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 9, 2019

@0xc0170 0xc0170 merged commit dc1198b into ARMmbed:master Apr 9, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10354 cycles (+343 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.